Re: [PATCH nft] payload: restore is_raw flag for th expressions parsed from udata

[Florian Westphal <fw@strlen.de>]

Adrian Moisey <adrian@changeover.za.net> wrote:
> payload_expr_parse_udata() restores the pseudo transport header (th)
> proto desc from set userdata, but not payload.is_raw. The bison and
> json parsers both set is_raw for raw th expressions, which makes
> evaluation skip the transport protocol conflict check. Without it,
> re-evaluating a map declared with 'typeof ... th dport ...' from a
> later transaction fails with a bogus
> 
>   conflicting transport layer protocols specified: tcp vs. th
> 
> Set is_raw when the restored desc is proto_th, just like the parsers
> do.
> 
> Signed-off-by: Adrian Moisey <adrian@changeover.za.net>
> ---
>  src/payload.c                                 |  3 ++
>  .../testcases/maps/typeof_maps_restore_0      | 28 +++++++++++++++++++
>  2 files changed, 31 insertions(+)
>  create mode 100755 tests/shell/testcases/maps/typeof_maps_restore_0

Hint: "run-tests.sh -g" also generates the dump files.

Just mentioning this for future submissions, patch is applied,
thanks.