From: Phil Sutter <phil@nwl.cc>
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
pablo@netfilter.org, fw@strlen.de
Subject: Re: [PATCH nf-next] netfilter: nft_nat: use the right enum members for nat type switch
Date: Tue, 22 Sep 2026 18:51:10 +0200 [thread overview]
Message-ID: <arKx_sYz5ExzhPwi@orbyte.nwl.cc> (raw)
In-Reply-To: <20260922164059.4320-1-fmancera@suse.de>
On Tue, Sep 22, 2026 at 06:40:59PM +0200, Fernando Fernandez Mancera wrote:
> The member 'type' from struct 'nft_nat' is of type enum
> nf_nat_manip_type but at the switch statements for
> nft_nat_setup_netmap() and nft_nat_validate() functions the members from
> nft_nat_types enum were used instead.
>
> This does not cause any problem but is worth fixing for correctness.
>
> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
Fixes: 3ff7ddb1353d ("netfilter: nft_nat: add netmap support")
Acked-by: Phil Sutter <phil@nwl.cc>
prev parent reply other threads:[~2026-09-22 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 16:40 [PATCH nf-next] netfilter: nft_nat: use the right enum members for nat type switch Fernando Fernandez Mancera
2026-09-22 16:51 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arKx_sYz5ExzhPwi@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=coreteam@netfilter.org \
--cc=fmancera@suse.de \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox