Linux Netfilter development
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH v2] Fix for warnings when compiling for 32bit arch
Date: Tue, 6 Oct 2026 11:30:18 +0200	[thread overview]
Message-ID: <asS_quHWadVhbEel@orbyte.nwl.cc> (raw)
In-Reply-To: <asK3PzqW4orq3BmH@chamomile>

On Sun, Oct 04, 2026 at 10:29:51PM +0200, Pablo Neira Ayuso wrote:
> On Fri, Oct 02, 2026 at 04:45:38PM +0200, Phil Sutter wrote:
> > This eliminates several, probably harmless warnings when e.g. compiling
> > with '-m32' for x86_64:
> > 
> > - Printing code assumes NFT_MAX_EXPR_LEN_BITS is unsigned long, when on
> >   32bit it is unsigned int - cast to uint32_t and print using '%d'.
> > 
> > - Pointers are unsigned long, casting to uint64_t yields a warning on
> >   32bit due to the different size
> > 
> > - Bison tokens of type 'val' are uint64_t, print their values using
> >   PRIu64 macro
> > 
> > - On 32bit, UINT32_MAX is of type unsigned int - cast to off_t when
> >   comparing against state->indesc->line_offset to avoid different
> >   signedness warning
> > 
> > Signed-off-by: Phil Sutter <phil@nwl.cc>
> 
> Tested-by: Pablo Neira Ayuso <pablo@netfilter.org>

Patch applied.


      reply	other threads:[~2026-10-06  9:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 14:45 [nft PATCH v2] Fix for warnings when compiling for 32bit arch Phil Sutter
2026-10-04 20:29 ` Pablo Neira Ayuso
2026-10-06  9:30   ` Phil Sutter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asS_quHWadVhbEel@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox