From: Florian Westphal <fw@strlen.de>
To: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] selftests: netfilter: fix return value in zone subtest
Date: Wed, 7 Oct 2026 13:32:04 +0200 [thread overview]
Message-ID: <asYttCJ5ZNjCPm1b@strlen.de> (raw)
In-Reply-To: <20261006230459.2139-1-fw@strlen.de>
Florian Westphal <fw@strlen.de> wrote:
> zone subtest prints FAIL, but did not set 'ret=1', so kselftest
> framework reports success.
>
> While at it, also fail when "nft -f" returns an error.
>
> Noticed thanks to a (broken) local patch that should have caused this
> selftest (resp. the kselftest framework) to report a failure.
https://sashiko.dev/#/patchset/20261006230459.2139-1-fw%40strlen.de
| Does this early return in test_masquerade_vrf() skip the qdisc cleanup?
Yes, but a great many other places don't clean up either.
Tests are supposed to pass, I don't think there is any point in
making scripts more complicated by cleaning up in FAIL cases too.
I don't plan to address this comment. LMK if you disagree.
next prev parent reply other threads:[~2026-10-07 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 23:04 [PATCH nf-next] selftests: netfilter: fix return value in zone subtest Florian Westphal
2026-10-07 11:32 ` Florian Westphal [this message]
2026-10-07 12:55 ` Fernando Fernandez Mancera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asYttCJ5ZNjCPm1b@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox