Linux Netfilter development
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Zixuan Chai <petalzu987@gmail.com>, Ren Wei <weir@nebusec.ai>,
	netfilter-devel@vger.kernel.org, phil@nwl.cc,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org, kaber@trash.net,
	vega@nebusec.ai
Subject: Re: [PATCH nf 0/1] netfilter: nf_ip6_checksum: validate checksum offset
Date: Fri, 9 Oct 2026 02:05:22 +0200	[thread overview]
Message-ID: <asgvwg6IpZfqcKYg@strlen.de> (raw)
In-Reply-To: <asgnV5XFaS3V8g4W@chamomile>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Thu, Oct 08, 2026 at 07:24:59PM +0200, Florian Westphal wrote:
> > Zixuan Chai <petalzu987@gmail.com> wrote:
> > > On Fri, 18 Sept 2026 at 22:15, Florian Westphal <fw@strlen.de> wrote:
> > > >
> > > > Florian Westphal <fw@strlen.de> wrote:
> > > > > > We will provide detailed information about the bug in this email,
> > > > > > along with a PoC to trigger it.
> > > > >
> > > > > patch is fine, but could you make another patch that either fixes
> > > > > ipv6_find_hdr() or ip6_packet_match() / nft_set_pktinfo_ipv6() as well?
> > 
> > FTR, ipv6_find_hdr() gained this check in
> > ee319bd3a0e9 ("ipv6: do not let ipv6_find_hdr() return an offset past the packet end")
> 
> Then this is fixed upstream in the core, now it validates that the
> offset provides enough room for the announced header.
> 
> This patch is now hardening that can follow up to nf-next using 
> DEBUG_NET_WARN_ON_ONCE?

Yes, I think this should get a v2, targetting nf-next.  It would also be
good to be consistent here: We have multiple interfaces:
nf_ip6_checksum, nf_checksum_partial, nf_ip6_checksum_partialm, nf_ip_checksum, ...

So I think there should be consistency there too, either none should
have checks or all of them should have DEBUG_NET_WARN_ON_ONCE() +
return where applicable.

      reply	other threads:[~2026-10-09  0:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18  9:26 [PATCH nf 0/1] netfilter: nf_ip6_checksum: validate checksum offset Ren Wei
2026-09-18  9:26 ` [PATCH nf 1/1] " Ren Wei
2026-09-18 10:38 ` [PATCH nf 0/1] " Florian Westphal
2026-09-18 11:33   ` Pablo Neira Ayuso
2026-09-18 14:15   ` Florian Westphal
2026-09-19 14:35     ` Zixuan Chai
2026-10-08 16:01     ` Zixuan Chai
2026-10-08 17:24       ` Florian Westphal
2026-10-08 23:29         ` Pablo Neira Ayuso
2026-10-09  0:05           ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asgvwg6IpZfqcKYg@strlen.de \
    --to=fw@strlen.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kaber@trash.net \
    --cc=kuba@kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=petalzu987@gmail.com \
    --cc=phil@nwl.cc \
    --cc=vega@nebusec.ai \
    --cc=weir@nebusec.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox