From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59AF2246BAA for ; Mon, 14 Jul 2025 12:06:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752494767; cv=none; b=KD7a4JTJTLZjA1FodtGS388DnpcjWMzKOxMAo73s5Ju+5ql7UuNMwUccsMxuJxKNoqTVG3K5+mUMZbu3ir6/wkaAVnUwd+R7MRiyxxTJqYryQez3qc/78lQj23o6Lz3MXNMFP5JIynzmK1PZhFuMJEpsPA04ENvgzE+WSDi89z0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752494767; c=relaxed/simple; bh=KhvodG7UPM4KmPvjXDLJRXih060ZGfuKaf5+gHJ+sEM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K9tGIbm6FcxO2IfF55ZBXIufEWAyIPdW/gHUXEEKmA3NrPm+9Gl3Js4r/1Re9UsLWhlRJ0Y+p8Bw9asvzz6kNQYPUrl7NuXbX1/jrCz3Ewck/S8ZyYg8hHS/WOUH0sV2FmRUrgnbr2/9K15gI9USo1BgTSxIvHlmhuZC5QBUpcA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=uv0b/mnJ; arc=none smtp.client-ip=91.218.175.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="uv0b/mnJ" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1752494761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3l4SjgR+dr12WvJvDbrOO5yU63BAL466Fxwff8lUU9E=; b=uv0b/mnJHcQAOFBxD9qhY6ic/RpYOck+TS/2jkWxc0Io2leTccD+sA+jF88y4vtlUaZQDA U+tvzSkhXuLSdAWKM2upBS7s+4A3KFtLTlWut8sppStDUA6gAkIObeznwKxKr1rQSMoUWK 4YIW0QoYhQnW+Of5duicolaBuHrcU+Y= Date: Mon, 14 Jul 2025 20:05:51 +0800 Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2 1/1] netfilter: load nf_log_syslog on enabling nf_conntrack_log_invalid Content-Language: en-US To: Florian Westphal Cc: pablo@netfilter.org, coreteam@netfilter.org, davem@davemloft.net, edumazet@google.com, horms@kernel.org, kadlec@netfilter.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, pabeni@redhat.com, zi.li@linux.dev, Lance Yang References: <20250526085902.36467-1-lance.yang@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2025/5/28 19:05, Florian Westphal wrote: > Lance Yang wrote: >> From: Lance Yang >> >> When no logger is registered, nf_conntrack_log_invalid fails to log invalid >> packets, leaving users unaware of actual invalid traffic. Improve this by >> loading nf_log_syslog, similar to how 'iptables -I FORWARD 1 -m conntrack >> --ctstate INVALID -j LOG' triggers it. > > Acked-by: Florian Westphal A gentle reminder for this patch, as the merge window is approaching ;) Please let me know if any changes are needed. Thanks, Lance