From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE3C56A8B0 for ; Thu, 8 Feb 2024 08:51:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707382265; cv=none; b=F0VKmf74xG+ZTLvVMrb+7mW0hlzlLAdxWz7VOm7HYXIp88/iHJg7Fz2+btpXKOrbrmPQVz4TWxMK4+HCFgZNDhyfa5y9+Uo1gNzXmzhompfyqjTYhm8gwmPcdlKEjK70N7Z4pNcuLgAOr3THrS0gD/eYB8b40kVLG9W+V+pktyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707382265; c=relaxed/simple; bh=7QZVCM+4Qz/KJoVHYq5ufx0w1n9m1drmdBnIdjI+ri8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=le7RDQuJK7IzWjB2dP0WZvhHqNdj6ZuVqJP01knIW3NIQpBP6dQi7f2ZoYOzpLf0uKW92ge4bmNUNzdq4UmnZTVIhTczXg4g2p/f6HWlzMjwywPG8YW9xscu/Ibd7ZoChzrW8NldB8RQdvPMERwxfHp65KhDLQUJRSR+BF2oa6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Sb9TLHSi; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Sb9TLHSi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707382262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0pp5+yA9x1/gF39Oadzq9Xuf1rHNKA+D7ZvahMSpMYg=; b=Sb9TLHSixg1OFwancKC7DAYCEa3E9T6S5jjaQWfD1s4TOjRic7dTENxXkHx9lB/mHd03Ay NTtVeooSNNo5oXP8YqQc2yP7p64AgBZm02ZQsyGO5RSqxn51HUYjeD8kZwVNOvW6w2jp/s KmkXXGuDNJy9NX8dJ4Q0IyEc8fhULjM= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-JC4csjMLN8OCFBT-5sMtIQ-1; Thu, 08 Feb 2024 03:50:59 -0500 X-MC-Unique: JC4csjMLN8OCFBT-5sMtIQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d0af6e4540so6175511fa.0 for ; Thu, 08 Feb 2024 00:50:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707382258; x=1707987058; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0pp5+yA9x1/gF39Oadzq9Xuf1rHNKA+D7ZvahMSpMYg=; b=IoF2mMylmWHoxjJXQ31LHhjgg9Z15cizx7hsxYRXyIWRz4Zcc6x7jcQZNc6p0aMMeo fJ9momW2OJwtyS41kODXeQ4TfNvq4snr42LhnhVfid3jlEsYHyBKnHx7+mtt2w6L1dkV 1Sx2mAtU9tFK85RuGFS5bpAZIzn5d2ncI165JDvTI/1VW1W5nQSzQAJd5KGmQ61SE4bG ihSnNAcHvcV6k2bdQ9nRBNGPPdmiDSjds9ipKs4FIn6F0Lrb8/eF5DpSlm/mDct00Enj BEoChZdqNJRUkdVrPyVl1eD9qH2J5OF3PZCO4Vdxl3Fw6nqQvQ2X4UQXL88JKM7EAZb2 BwjA== X-Gm-Message-State: AOJu0YxsUdnIAichMuC4pwsd/4vtdn70NtLCNJIHRe/9pglUdsKhGauD dC88KW4lKj7hBBX4V3hxI2GSnlppWr6khgrigTJp8c1DTag5/KURh1v2eay0H3IJ77l/zb9Ujzc vVz9Rz/EwRmddYoicUIC/UoLf5cgDlQAWr64O3KI+aoVjZHG6vpWAotAovOk6JhFNng== X-Received: by 2002:a2e:a315:0:b0:2cd:fb0e:1f68 with SMTP id l21-20020a2ea315000000b002cdfb0e1f68mr5535361lje.5.1707382258341; Thu, 08 Feb 2024 00:50:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGmNAP1Y0RAOw3TDUgJIwsHL2IMqC/u00qeUJtFmR21pA8Q/sNvgtKeVDntmBNBvzUL3rtUNg== X-Received: by 2002:a2e:a315:0:b0:2cd:fb0e:1f68 with SMTP id l21-20020a2ea315000000b002cdfb0e1f68mr5535350lje.5.1707382257995; Thu, 08 Feb 2024 00:50:57 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVis8dKgy7hTUMgbWW2teg/IoY6w03/yaKWpBt7wgLmWyQ0QqqYejrTVEXbeRAbSZ5QjE45Zepc1MXA/nulUM+Xk8Vx8s+Fe81TuCMq24u42An+LRfnQX3TMYrgkuTPwS9fQBx4aYo7b5R+ywsQGgg5lB9tyAS+eSH9fHYt9QkHeHd3vjQFyDLPnduHFNly9AiHrRYD9WwXb6NXsA== Received: from gerbillo.redhat.com (146-241-238-112.dyn.eolo.it. [146.241.238.112]) by smtp.gmail.com with ESMTPSA id 7-20020a05651c040700b002d08f3640b5sm425954lja.11.2024.02.08.00.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 00:50:57 -0800 (PST) Message-ID: Subject: Re: [PATCH net 05/13] netfilter: ipset: Missing gc cancellations fixed From: Paolo Abeni To: Pablo Neira Ayuso Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org, edumazet@google.com, fw@strlen.de, netfilter-devel@vger.kernel.org Date: Thu, 08 Feb 2024 09:50:55 +0100 In-Reply-To: <9fb4e908-832c-44ae-8049-f6e9092f9b10@leemhuis.info> References: <20240207233726.331592-1-pablo@netfilter.org> <20240207233726.331592-6-pablo@netfilter.org> <9fb4e908-832c-44ae-8049-f6e9092f9b10@leemhuis.info> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, On Thu, 2024-02-08 at 06:48 +0100, Thorsten Leemhuis wrote: > On 08.02.24 00:37, Pablo Neira Ayuso wrote: > > From: Jozsef Kadlecsik > >=20 > > The patch fdb8e12cc2cc ("netfilter: ipset: fix performance regression > > in swap operation") missed to add the calls to gc cancellations > > at the error path of create operations and at module unload. Also, > > because the half of the destroy operations now executed by a > > function registered by call_rcu(), neither NFNL_SUBSYS_IPSET mutex > > or rcu read lock is held and therefore the checking of them results > > false warnings. > >=20 > > Reported-by: syzbot+52bbc0ad036f6f0d4a25@syzkaller.appspotmail.com > > Reported-by: Brad Spengler > > Reported-by: =D0=A1=D1=82=D0=B0=D1=81 =D0=9D=D0=B8=D1=87=D0=B8=D0=BF=D0= =BE=D1=80=D0=BE=D0=B2=D0=B8=D1=87 > > Fixes: fdb8e12cc2cc ("netfilter: ipset: fix performance regression in s= wap operation") >=20 > FWIW, in case anyone cares: that afaics should be >=20 > Fixes: 97f7cf1cd80e ("netfilter: ipset: fix performance regression in sw= ap operation") >=20 > instead, as noted yesterday elsewhere[1]. >=20 > Ciao, Thorsten >=20 > [1] https://lore.kernel.org/all/07cf1cf8-825e-47b9-9837-f91ae958dd6b@leem= huis.info/ I think it would be better to update the commit message, to help stable teams.=20 Unless you absolutely need series in today PR, could you please send out a v2? Note that if v2 comes soon enough it can still land into the mentioned PR. Thanks, Paolo