From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Dobriyan Subject: Re: debug: nt_conntrack and KVM crash Date: Mon, 1 Feb 2010 12:44:49 +0200 Message-ID: References: <1264813832.2793.446.camel@tonnant> <1264816634.2793.505.camel@tonnant> <1264816777.2793.510.camel@tonnant> <1264834704.2919.3.camel@edumazet-laptop> <1265016745.7499.144.camel@tonnant> <1265020552.7499.147.camel@tonnant> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Eric Dumazet , linux-kernel , netdev , netfilter-devel , Patrick McHardy To: Jon Masters Return-path: Received: from mail-iw0-f186.google.com ([209.85.223.186]:42474 "EHLO mail-iw0-f186.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778Ab0BAKot (ORCPT ); Mon, 1 Feb 2010 05:44:49 -0500 In-Reply-To: <1265020552.7499.147.camel@tonnant> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Mon, Feb 1, 2010 at 12:35 PM, Jon Masters wrote: > On Mon, 2010-02-01 at 11:36 +0200, Alexey Dobriyan wrote: >> On Mon, Feb 1, 2010 at 11:32 AM, Jon Masters wrote: >> > I hacked up a per-namespace version of hashtables (this needs doing >> > anyway, since the global stuff is just waiting to break) >> >> Which ones? Conntrack hashtables are per-netns. > > They are, but the metadata is not. Sorry for not being clear, but my > previous mail was. i.e. there is a per-netns hashtable that is indexed > using a global that might change at any time underneath. The htable size > and max should be per-netns too. So, insert printk into nf_conntrack_set_hashsize(). > An existing sysctl/module parameter affects these and should also > ultimately either iterate through namespaces, or only affect the global > init_net (as it almost does now, except it changes the data used by the > others and doesn't resize them). Those sysctls are readonly, nobody else changes hashtable size legitimately. Alexey, hoping sysfs code for modules is not too smart.