From: Alexey Dobriyan <adobriyan@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v0] netns NOTRACK
Date: Fri, 12 Feb 2010 14:32:08 +0200 [thread overview]
Message-ID: <b6fcc0a1002120432t133ef769jc877d92b1f106af2@mail.gmail.com> (raw)
In-Reply-To: <4B744565.2010808@trash.net>
On Thu, Feb 11, 2010 at 7:59 PM, Patrick McHardy <kaber@trash.net> wrote:
> Alexey Dobriyan wrote:
>> --- a/net/bridge/br_netfilter.c
>> +++ b/net/bridge/br_netfilter.c
>> @@ -792,9 +792,11 @@ static unsigned int br_nf_local_out(unsigned int hook, struct sk_buff *skb,
>> }
>>
>> #if defined(CONFIG_NF_CONNTRACK_IPV4) || defined(CONFIG_NF_CONNTRACK_IPV4_MODULE)
>> +#include <net/netfilter/nf_conntrack.h>
>> +
>> static int br_nf_dev_queue_xmit(struct sk_buff *skb)
>> {
>> - if (skb->nfct != NULL &&
>> + if ((skb->nfct != NULL || nf_ct_is_untracked(skb)) &&
>
> Seems unnecessary since nfct should be NULL when the conntrack
> is untracked.
Before untracked connections would pass the test, so additional check required.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-02-12 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 17:31 [PATCH v0] netns NOTRACK Alexey Dobriyan
2010-02-11 17:59 ` Patrick McHardy
2010-02-11 18:04 ` Jan Engelhardt
2010-02-12 12:24 ` Alexey Dobriyan
2010-02-12 12:36 ` Jan Engelhardt
2010-02-12 12:32 ` Alexey Dobriyan [this message]
2010-02-12 14:45 ` Patrick McHardy
2010-02-12 12:42 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6fcc0a1002120432t133ef769jc877d92b1f106af2@mail.gmail.com \
--to=adobriyan@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).