From: Hannes Reinecke <hare@suse.de>
To: Florian Westphal <fw@strlen.de>, Yadan Fan <ydfan@suse.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
netfilter-devel@vger.kernel.org,
Michal Kubecek <mkubecek@suse.de>,
Hannes Reinecke <hare@kernel.org>
Subject: Re: [PATCH] nf_conntrack_proto_udp: Set ASSURED for NAT_CLASH entries to avoid packets dropped
Date: Thu, 10 Oct 2024 14:49:15 +0200 [thread overview]
Message-ID: <b83a3a26-8806-40e6-8aa3-84fe3fe4517a@suse.de> (raw)
In-Reply-To: <20241010124708.GB30424@breakpoint.cc>
On 10/10/24 14:47, Florian Westphal wrote:
> Yadan Fan <ydfan@suse.com> wrote:
>> c46172147ebb brought the logic that never setting ASSURED to drop NAT_CLASH replies
>> in case server is very busy and early_drop logic kicks in.
>>
>> However, this will drop all subsequent UDP packets that sent through multiple threads
>> of application, we already had a customer reported this issue that impacts their business,
>> so deleting this logic to avoid this issue at the moment.
>>
>> Fixes: c46172147ebb ("netfilter: conntrack: do not auto-delete clash entries on reply")
>>
>> Signed-off-by: Yadan Fan <ydfan@suse.com>
>
>
> Acked-by: Florian Westphal <fw@strlen.de>
You probably need mine:
Signed-off-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2024-10-10 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 12:19 [PATCH] nf_conntrack_proto_udp: Set ASSURED for NAT_CLASH entries to avoid packets dropped Yadan Fan
2024-10-10 12:47 ` Florian Westphal
2024-10-10 12:49 ` Hannes Reinecke [this message]
2024-11-10 11:16 ` Yadan Fan
2024-11-11 9:56 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b83a3a26-8806-40e6-8aa3-84fe3fe4517a@suse.de \
--to=hare@suse.de \
--cc=fw@strlen.de \
--cc=hare@kernel.org \
--cc=kadlec@netfilter.org \
--cc=mkubecek@suse.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=ydfan@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).