From mboxrd@z Thu Jan 1 00:00:00 1970 From: "luo kaih" Subject: [PATCH] netfilter: xt_time gives a wrong monthday in a leap year Date: Tue, 26 Aug 2008 09:03:43 +0800 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: trivial@kernel.org, linux-kernel@vger.kernel.org To: netfilter-devel@vger.kernel.org Return-path: Received: from qb-out-0506.google.com ([72.14.204.228]:9816 "EHLO qb-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753553AbYHZBDp (ORCPT ); Mon, 25 Aug 2008 21:03:45 -0400 Received: by qb-out-0506.google.com with SMTP id a16so2932289qbd.17 for ; Mon, 25 Aug 2008 18:03:44 -0700 (PDT) Content-Disposition: inline Sender: netfilter-devel-owner@vger.kernel.org List-ID: the function localtime_3 in xt_time.c gives a wrong monthday in a leap year after 28th 2 . calculating monthday should use the array days_since_leapyear[] not days_since_year[] in a leap year . Signed-off-by: Kaihui Luo --- --- linux-2.6.26/net/netfilter/xt_time.c.orig 2008-08-25 11:59:46.000000000 +0800 +++ linux-2.6.26/net/netfilter/xt_time.c 2008-08-25 12:16:12.000000000 +0800 @@ -136,17 +136,19 @@ static void localtime_3(struct xtm *r, t * from w repeatedly while counting.) */ if (is_leap(year)) { + /* use days_since_leapyear[] in a leap year */ for (i = ARRAY_SIZE(days_since_leapyear) - 1; - i > 0 && days_since_year[i] > w; --i) + i > 0 && days_since_leapyear[i] > w; --i) /* just loop */; + r->monthday = w - days_since_leapyear[i] + 1; } else { for (i = ARRAY_SIZE(days_since_year) - 1; i > 0 && days_since_year[i] > w; --i) /* just loop */; + r->monthday = w - days_since_year[i] + 1; } r->month = i + 1; - r->monthday = w - days_since_year[i] + 1; return; }