Re: [nft v2 PATCH 2/3] nftables: add input flag NFT_CTX_INPUT_NO_DNS to avoid blocking getaddrinfo()

[Thomas Haller <thaller@redhat.com>]

On Fri, 2023-07-14 at 12:07 +0200, Phil Sutter wrote:
> On Fri, Jul 14, 2023 at 10:48:52AM +0200, Thomas Haller wrote:
> > 
> > +static void parse_ctx_init(struct parse_ctx *parse_ctx, const
> > struct eval_ctx *ctx)
> > +{
> > +       *parse_ctx = (struct parse_ctx) {
> > +               .tbl    = &ctx->nft->output.tbl,
> > +               .input  = &ctx->nft->input,
> > +       };
> > +}
> 
> This is interesting coding style, but looks more complicated than

> 
> > parse_ctx->tbl  = &ctx->nft->output.tbl;
> > parse_ctx->input        = &ctx->nft->input;
> 
> though I would just keep the extra assignment inline like so:

> 
> > -       struct parse_ctx parse_ctx = { .tbl = &ctx->nft-
> > >output.tbl, };
> > +       struct parse_ctx parse_ctx = {
> > +               .tbl    = &ctx->nft->output.tbl,
> > +               .input  = &ctx->nft->input,
> > +       };
> 
> Cheers, Phil

Hi,

I will address this in an update.

Thomas