From: Thomas Graf <tgraf@suug.ch>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kaber@trash.net,
paulmck@linux.vnet.ibm.com, josh@joshtriplett.org,
challa@noironetworks.com, walpole@cs.pdx.edu,
dev@openvswitch.org, tklauser@distanz.ch,
netfilter-devel@vger.kernel.org
Subject: [PATCH v2 0/3 net-next] Lockless netlink_lookup() with new concurrent hash table
Date: Fri, 1 Aug 2014 00:56:00 +0200 [thread overview]
Message-ID: <cover.1406846586.git.tgraf@suug.ch> (raw)
Netlink sockets are maintained in a hash table to allow efficient lookup
via the port ID for unicast messages. However, lookups currently require
a read lock to be taken. This series adds a new generic, resizable,
scalable, concurrent hash table based on the paper referenced in the first
patch. It then makes use of the new data type to implement lockless
netlink_lookup().
Patch 3/3 to convert nft_hash is included for reference but should be
merged via the netfilter tree. Inclusion in this series is to provide
context for the suggested API.
Against net-next since the initial user of the new hash table is in net/
Changes:
v1-v2:
- fixed traversal off-by-one as spotted by Tobias Klauser
- removed unlikely() from BUG_ON() as spotted by Josh Triplett
- new 3rd patch to convert nft_hash to rhashtable
- make rhashtable_insert() return void
- nl_sk_hash_lock must be a mutex
- fixed wrong name of rht_shrink_below_30()
- exported symbols rht_grow_above_75() and rht_shrink_below_30()
- allow table freeing with RCU callback
Thomas Graf (3):
lib: Resizable, Scalable, Concurrent Hash Table
netlink: Convert netlink_lookup() to use RCU protected hash table
nftables: Convert nft_hash to use generic rhashtable
include/linux/rhashtable.h | 213 ++++++++++++
lib/Kconfig.debug | 8 +
lib/Makefile | 2 +-
lib/rhashtable.c | 797 +++++++++++++++++++++++++++++++++++++++++++++
net/netfilter/nft_hash.c | 291 +++--------------
net/netlink/af_netlink.c | 285 ++++++----------
net/netlink/af_netlink.h | 18 +-
net/netlink/diag.c | 11 +-
8 files changed, 1190 insertions(+), 435 deletions(-)
create mode 100644 include/linux/rhashtable.h
create mode 100644 lib/rhashtable.c
--
1.9.3
next reply other threads:[~2014-07-31 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 22:56 Thomas Graf [this message]
[not found] ` <cover.1406846586.git.tgraf-G/eBtMaohhA@public.gmane.org>
2014-07-31 22:56 ` [PATCH net-next 1/3] lib: Resizable, Scalable, Concurrent Hash Table Thomas Graf
2014-07-31 22:56 ` [PATCH net-next 2/3] netlink: Convert netlink_lookup() to use RCU protected hash table Thomas Graf
2014-07-31 22:56 ` [PATCH net-next 3/3] nftables: Convert nft_hash to use generic rhashtable Thomas Graf
2014-08-01 5:39 ` [PATCH v2 0/3 net-next] Lockless netlink_lookup() with new concurrent hash table David Miller
[not found] ` <20140731.223946.2222491319947824077.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-08-01 5:46 ` David Miller
[not found] ` <20140731.224659.1839149761075616147.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-08-01 8:50 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1406846586.git.tgraf@suug.ch \
--to=tgraf@suug.ch \
--cc=challa@noironetworks.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=josh@joshtriplett.org \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tklauser@distanz.ch \
--cc=walpole@cs.pdx.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).