From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, Flavio Leitner <fbl@redhat.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
David Miller <davem@davemloft.net>,
Florian Westphal <fw@strlen.de>,
NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: preserve sock reference when scrubbing the skb.
Date: Tue, 26 Jun 2018 19:32:32 -0700 [thread overview]
Message-ID: <da3d006d-de11-f308-2a99-98a43c06fbb5@gmail.com> (raw)
In-Reply-To: <CAM_iQpVmbuVK+pfhad7HrQtaSxFbe7K=59_34f0BwxoP_=W0VQ@mail.gmail.com>
On 06/26/2018 05:29 PM, Cong Wang wrote:
> On Tue, Jun 26, 2018 at 4:33 PM Flavio Leitner <fbl@redhat.com> wrote:
>>
>> It is still isolated, the sk carries the netns info and it is
>> orphaned when it re-enters the stack.
>
> Then what difference does your patch make?
>
> Before your patch:
> veth orphans skb in its xmit
>
> After your patch:
> RX orphans it when re-entering stack (as you claimed, I don't know)
>
> And for veth pair:
> xmit from one side is RX for the other side
>
> So, where is the queueing? Where is the buffer bloat? GRO list??
>
By re-entering the stack, Flavio probably meant storing this skb in
a socket receive queue, or anything that should already modify skb->destructor
(and thus call skb_orphan() before the modification)
If skb sits in some qdisc, like fq on ipvlan master device, we do not want skb->sk to be scrubbed,
just because ipvlan slave and master might be in different netns.
next prev parent reply other threads:[~2018-06-27 2:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 15:56 [PATCH net-next] net: preserve sock reference when scrubbing the skb Flavio Leitner
2018-06-26 4:15 ` Cong Wang
2018-06-26 6:41 ` Eric Dumazet
2018-06-26 12:38 ` Flavio Leitner
2018-06-26 13:06 ` Eric Dumazet
2018-06-26 13:32 ` Flavio Leitner
2018-06-26 21:48 ` Cong Wang
2018-06-26 22:03 ` Flavio Leitner
2018-06-26 22:47 ` Cong Wang
2018-06-26 23:33 ` Flavio Leitner
2018-06-27 0:29 ` Cong Wang
2018-06-27 0:39 ` Flavio Leitner
2018-06-27 1:28 ` Cong Wang
2018-06-27 12:31 ` Flavio Leitner
2018-06-27 19:06 ` Cong Wang
2018-06-27 20:19 ` Flavio Leitner
2018-06-28 21:51 ` Cong Wang
2018-06-27 2:32 ` Eric Dumazet [this message]
2018-06-26 23:53 ` Eric Dumazet
2018-06-27 0:44 ` Cong Wang
2018-06-27 2:35 ` Eric Dumazet
2018-06-27 18:59 ` Cong Wang
2018-06-27 19:33 ` Eric Dumazet
2018-06-27 19:55 ` Cong Wang
2018-06-28 23:18 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da3d006d-de11-f308-2a99-98a43c06fbb5@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=fbl@redhat.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).