From: Ander Juaristi <a@juaristi.eus>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Phil Sutter <phil@nwl.cc>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] tests/py: Set a fixed timezone in nft-test.py
Date: Tue, 19 Nov 2019 12:06:23 +0100 [thread overview]
Message-ID: <db71e3276085bccce877215254bbfc21@juaristi.eus> (raw)
In-Reply-To: <20191118183459.qkqztuc5pn4fezzn@salvia>
El 2019-11-18 19:34, Pablo Neira Ayuso escribió:
> Hi Phil,
>
> On Sat, Nov 16, 2019 at 10:32:18PM +0100, Phil Sutter wrote:
>> Payload generated for 'meta time' matches depends on host's timezone
>> and
>> DST setting. To produce constant output, set a fixed timezone in
>> nft-test.py. Choose UTC-2 since most payloads are correct then, adjust
>> the remaining two tests.
>
> This means that the ruleset listing for the user changes when daylight
> saving occurs, right? Just like it happened to our tests.
It shouldn't, as the date is converted to a timestamp that doesn't take
DST into account (using timegm(3), which is Linux-specific).
The problem is that payloads are hard-coded in the tests.
Correct me if I'm missing something.
>
> Thanks.
next prev parent reply other threads:[~2019-11-19 11:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 21:32 [nft PATCH] tests/py: Set a fixed timezone in nft-test.py Phil Sutter
2019-11-18 8:20 ` Ander Juaristi
2019-11-18 18:34 ` Pablo Neira Ayuso
2019-11-19 0:20 ` Phil Sutter
2019-11-19 11:06 ` Ander Juaristi [this message]
2019-11-19 22:12 ` Pablo Neira Ayuso
2019-11-19 22:20 ` Phil Sutter
2019-11-19 22:33 ` Pablo Neira Ayuso
2019-11-20 11:45 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db71e3276085bccce877215254bbfc21@juaristi.eus \
--to=a@juaristi.eus \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).