From: Edward Cree <ecree@solarflare.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: <netfilter-devel@vger.kernel.org>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <jiri@resnulli.us>, <kuba@kernel.org>
Subject: Re: [PATCH net,v4] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DONT_CARE
Date: Thu, 7 May 2020 13:15:37 +0100 [thread overview]
Message-ID: <dbe545f3-b041-ffe4-a908-f7e29afa322d@solarflare.com> (raw)
In-Reply-To: <20200507114400.GA2179@salvia>
On 07/05/2020 12:44, Pablo Neira Ayuso wrote:
> Could you point to what driver might have any problem with this update?
Drivers *can* implement the API in this patch. It's just that the
alternative API Jakub proposed would make for simpler driver code.
I.e. I'm not saying it's bad, just that it could be made better.
That's why I didn't hard-NACK it at any point.
I guess I should send the change I'm suggesting as a patch, rather
than asking it of you — I'll try to get that done today.
(Although I'm not sure if it's really 'net' material or if I should
wait for David to merge net into net-next and make the patch
against the latter — wdyt?)
-ed
prev parent reply other threads:[~2020-05-07 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 18:34 [PATCH net,v4] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DONT_CARE Pablo Neira Ayuso
2020-05-07 3:14 ` David Miller
2020-05-07 10:38 ` Edward Cree
2020-05-07 11:44 ` Pablo Neira Ayuso
2020-05-07 12:15 ` Edward Cree [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbe545f3-b041-ffe4-a908-f7e29afa322d@solarflare.com \
--to=ecree@solarflare.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).