From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: coreteam@netfilter.org, David Miller <davem@davemloft.net>,
Florian Westphal <fw@strlen.de>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
LKML <linux-kernel@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: WARNING in __proc_create
Date: Fri, 9 Mar 2018 15:42:53 -0800 [thread overview]
Message-ID: <ddcf91b3-8526-bac5-d2bb-c5a39deeaac1@gmail.com> (raw)
In-Reply-To: <CAM_iQpXPO_9=sj1DiMRfNmhZkUnCaoJtWw2O82g9AKSYjRFrZA@mail.gmail.com>
On 03/09/2018 03:32 PM, Cong Wang wrote:
> On Fri, Mar 9, 2018 at 3:21 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>>
>>
>> On 03/09/2018 03:05 PM, Cong Wang wrote:
>>>
>>>
>>> BTW, the warning itself is all about empty names, so perhaps
>>> it's better to fix them separately.
>>
>>
>> Huh ? You want more syzbot reports ? I do not.
>
> I always prefer one patch to fix one problem, and, as I already said,
> checking "." and ".." is probably not as trivial as checking empty.
>
> This why I believe 2 (or more) patches here are better than 1 single
> patch.
>
> BTW, I don't have any patch, it is so trivial that I don't want to spend
> my time on it.
The trivial patch has been sent, and Florian gave a (very good) feedback.
Then Pablo offered to write a complete patch.
They both had more pressing issues, and quite frankly I also had more
pressing issues.
I doubt that sending again the simple fix will be accepted by netfilter
maintainers.
next prev parent reply other threads:[~2018-03-09 23:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 21:59 WARNING in __proc_create syzbot
2018-03-09 22:48 ` Cong Wang
2018-03-09 22:56 ` Eric Dumazet
2018-03-09 22:58 ` Eric Dumazet
2018-03-09 23:05 ` Cong Wang
2018-03-09 23:18 ` Florian Westphal
2018-03-09 23:21 ` Eric Dumazet
2018-03-09 23:32 ` Cong Wang
2018-03-09 23:42 ` Eric Dumazet [this message]
2018-03-09 23:02 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddcf91b3-8526-bac5-d2bb-c5a39deeaac1@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).