From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: WARNING in __proc_create Date: Fri, 9 Mar 2018 15:42:53 -0800 Message-ID: References: <001a113f2be668a1e9056701e617@google.com> <5d89ba78-64b4-9c9b-c9f3-c67094343c3f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: coreteam@netfilter.org, David Miller , Florian Westphal , Jozsef Kadlecsik , LKML , Linux Kernel Network Developers , netfilter-devel@vger.kernel.org, Pablo Neira Ayuso To: Cong Wang Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On 03/09/2018 03:32 PM, Cong Wang wrote: > On Fri, Mar 9, 2018 at 3:21 PM, Eric Dumazet wrote: >> >> >> On 03/09/2018 03:05 PM, Cong Wang wrote: >>> >>> >>> BTW, the warning itself is all about empty names, so perhaps >>> it's better to fix them separately. >> >> >> Huh ? You want more syzbot reports ? I do not. > > I always prefer one patch to fix one problem, and, as I already said, > checking "." and ".." is probably not as trivial as checking empty. > > This why I believe 2 (or more) patches here are better than 1 single > patch. > > BTW, I don't have any patch, it is so trivial that I don't want to spend > my time on it. The trivial patch has been sent, and Florian gave a (very good) feedback. Then Pablo offered to write a complete patch. They both had more pressing issues, and quite frankly I also had more pressing issues. I doubt that sending again the simple fix will be accepted by netfilter maintainers.