From: Thomas Haller <thaller@redhat.com>
To: Florian Westphal <fw@strlen.de>
Cc: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft v3 00/11] tests/shell: allow running tests as
Date: Tue, 05 Sep 2023 14:03:26 +0200 [thread overview]
Message-ID: <e333c1c8d7b95591acdb8603fa7768af9299bafc.camel@redhat.com> (raw)
In-Reply-To: <20230905110915.GD3531@breakpoint.cc>
On Tue, 2023-09-05 at 13:09 +0200, Florian Westphal wrote:
> Thomas Haller <thaller@redhat.com> wrote:
> > Ch;anges to v3:
>
> I was about to apply this but 10 tests now fail for me because they
> no longer execute as real root and hit the socket buffer limits.
>
> Please fix this, the default needs to be 'all tests pass',
> i.e. use plain 'unshare -n' by default.
>
> I'll leave it up to you if you want to automatically go with
> unpriv netns if the script is invoked as non-root user or via
> env/cmdline switch.
>
> At least one failure isn't your fault, the blame is
> with a shortcut check in sets/0043concatenated_ranges_0, so the test
> never execeuted fully in the past. I will try
> to figure out when this got broken :/
>
hi,
yes, I noticed. Sorry about that.
Please see v4. That works well for me.
A major benefit IMO (which doesn't become clear from the commit
messages) is the result data in "/tmp/nft-test.latest". Have a look
there. And try the new "-j" option. And of course, try without root.
Thanks
Thomas
next prev parent reply other threads:[~2023-09-05 16:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 13:48 [PATCH nft v3 00/11] tests/shell: allow running tests as Thomas Haller
2023-09-04 13:48 ` [PATCH nft v3 01/11] tests/shell: rework command line parsing in "run-tests.sh" Thomas Haller
2023-09-04 13:48 ` [PATCH nft v3 02/11] tests/shell: rework finding tests and add "--list-tests" option Thomas Haller
2023-09-04 13:48 ` [PATCH nft v3 03/11] tests/shell: check test names before start and support directories Thomas Haller
2023-09-04 13:48 ` [PATCH nft v3 04/11] tests/shell: export NFT_TEST_BASEDIR and NFT_TEST_TMPDIR for tests Thomas Haller
2023-09-04 13:48 ` [PATCH nft v3 05/11] tests/shell: run each test in separate namespace and allow rootless Thomas Haller
2023-09-04 13:48 ` [PATCH nft v3 06/11] tests/shell: interpret an exit code of 77 from scripts as "skipped" Thomas Haller
2023-09-04 13:48 ` [PATCH nft v3 07/11] tests/shell: support --keep-logs option (NFT_TEST_KEEP_LOGS=y) to preserve test output Thomas Haller
2023-09-04 13:48 ` [PATCH nft v3 08/11] tests/shell: move the dump diff handling inside "test-wrapper.sh" Thomas Haller
2023-09-04 13:48 ` [PATCH nft v3 09/11] tests/shell: rework printing of test results Thomas Haller
2023-09-04 13:48 ` [PATCH nft v3 10/11] tests/shell: move taint check to "test-wrapper.sh" Thomas Haller
2023-09-04 13:48 ` [PATCH nft v3 11/11] tests/shell: support running tests in parallel Thomas Haller
2023-09-05 11:09 ` [PATCH nft v3 00/11] tests/shell: allow running tests as Florian Westphal
2023-09-05 12:03 ` Thomas Haller [this message]
2023-09-05 13:48 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e333c1c8d7b95591acdb8603fa7768af9299bafc.camel@redhat.com \
--to=thaller@redhat.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).