From: Edward Cree <ecree.xilinx@gmail.com>
To: pablo@netfilter.org
Cc: Network Development <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org
Subject: Conntrack offload and ingress_ifindex
Date: Fri, 1 Apr 2022 11:40:52 +0100 [thread overview]
Message-ID: <e4ba278d-3308-ada8-d4ab-4d3a6c489216@gmail.com> (raw)
Pablo,
When developing a conntrack offload driver, I was quite surprised to find
that CT entries passed to the driver's flow-block callback (as registered
with nf_flow_table_offload_add_cb()) include a match on ingress_ifindex,
with mask 0xffffffff and key 0. This is especially confusing as AIUI 0 is
not a valid ifindex.
From reading the calling code, looking at git logs etc, I can't determine
the intended semantics of this match; could you clarify what (if anything)
drivers are expected to do with it?
(Looking at other drivers it appears that e.g. mlx5e simply ignores it, as
its test for `key & mask` in mlx5_tc_ct_set_tuple_match() will be false.)
-ed
reply other threads:[~2022-04-01 10:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4ba278d-3308-ada8-d4ab-4d3a6c489216@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).