From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0647DC04A6A for ; Wed, 16 Aug 2023 12:25:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236364AbjHPMZT (ORCPT ); Wed, 16 Aug 2023 08:25:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245152AbjHPMY7 (ORCPT ); Wed, 16 Aug 2023 08:24:59 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F8E9E56; Wed, 16 Aug 2023 05:24:57 -0700 (PDT) Received: from dggpemm500016.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4RQnNk3X8vz1GDcX; Wed, 16 Aug 2023 20:23:34 +0800 (CST) Received: from [10.67.110.48] (10.67.110.48) by dggpemm500016.china.huawei.com (7.185.36.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 16 Aug 2023 20:24:54 +0800 Message-ID: Date: Wed, 16 Aug 2023 20:24:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH net-next v2] netfilter: ebtables: replace zero-length array members Content-Language: en-US To: Simon Horman , "GONG, Ruiqi" CC: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Roopa Prabhu , Nikolay Aleksandrov , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Kees Cook , "Gustavo A . R . Silva" , , , , , References: <20230816093443.1460204-1-gongruiqi@huaweicloud.com> From: Gong Ruiqi In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.110.48] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500016.china.huawei.com (7.185.36.25) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On 2023/08/16 19:16, Simon Horman wrote: > On Wed, Aug 16, 2023 at 05:34:43PM +0800, GONG, Ruiqi wrote: >> From: "GONG, Ruiqi" >> >> As suggested by Kees[1], replace the old-style 0-element array members >> of multiple structs in ebtables.h with modern C99 flexible array. >> >> [1]: https://lore.kernel.org/all/5E8E0F9C-EE3F-4B0D-B827-DC47397E2A4A@kernel.org/ >> >> Link: https://github.com/KSPP/linux/issues/21 >> Signed-off-by: GONG, Ruiqi >> Reviewed-by: Kees Cook >> --- >> >> v2: designate to net-next; cc more netdev maintainers > > It's slightly unclear to me if this should be targeting > net-next or nf-next. But regardless, it doesn't seem > to apply cleanly to the main branch of either tree. I find out that it's because this patch depends on a previous patch I've just sent: [v4] netfilter: ebtables: fix fortify warnings in size_entry_mwt() Maybe I should make them two into a patch set? Otherwise if I adapt this patch to net-next, it won't be applied either if the above patch is applied ... > > Please consider resolving that and posting again, > being sure to allow 24h before postings. > > Link: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html >