From: Fernando Fernandez Mancera <fmancera@suse.de>
To: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nft_meta_bridge: add validate callback for get operations
Date: Thu, 18 Jun 2026 17:15:38 +0200 [thread overview]
Message-ID: <eb7af2bc-fe6c-4c13-b21d-e5dba3f47bea@suse.de> (raw)
In-Reply-To: <20260618061631.21919-1-fw@strlen.de>
On 6/18/26 8:16 AM, Florian Westphal wrote:
> Blamed commit added NFT_META_BRI_IIFHWADDR to the set validate callback,
> yet this is a get operation.
>
> Add a get validate callback and move the NFT_META_BRI_IIFHWADDR key
> there.
>
> AFAICS this is harmless, NFT_META_BRI_IIFHWADDR can deal with a NULL
> input device and the set handler ignores a NFT_META_BRI_IIFHWADDR
> operation, but it allows to read 4 bytes off bridge skb->cb[].
>
> Fixes: cbd2257dc96e ("netfilter: nft_meta_bridge: introduce NFT_META_BRI_IIFHWADDR support")
> Signed-off-by: Florian Westphal <fw@strlen.de>
Thank you Florian, LGTM.
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
prev parent reply other threads:[~2026-06-18 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 6:16 [PATCH nf] netfilter: nft_meta_bridge: add validate callback for get operations Florian Westphal
2026-06-18 15:15 ` Fernando Fernandez Mancera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb7af2bc-fe6c-4c13-b21d-e5dba3f47bea@suse.de \
--to=fmancera@suse.de \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox