From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2] netfilter: xt_socket: Restore mark from full sockets only
Date: Thu, 21 Sep 2017 18:09:30 -0600 [thread overview]
Message-ID: <edf29b9f6c0924c53de486defb8875f8@codeaurora.org> (raw)
In-Reply-To: <1506038499.29839.156.camel@edumazet-glaptop3.roam.corp.google.com>
On 2017-09-21 18:01, Eric Dumazet wrote:
> On Thu, 2017-09-21 at 16:08 -0600, Subash Abhinov Kasiviswanathan
> wrote:
>> An out of bounds error was detected on an ARM64 target with
>> Android based kernel 4.9. This occurs while trying to
>> restore mark on a skb from an inet request socket.
>>
>> BUG: KASAN: slab-out-of-bounds in socket_match.isra.2+0xc8/0x1f0
>> net/netfilter/xt_socket.c:248
>> Read of size 4 at addr ffffffc06a8d824c by task syz-fuzzer/1532
>> CPU: 7 PID: 1532 Comm: syz-fuzzer Tainted: G W O 4.9.41+ #1
>> Call trace:
>
>>
>> v1->v2: Change socket_mt6_v1_v2_v3() as well as mentioned by Eric
>>
>> Fixes: a94070000388 ("netfilter: xt_socket: prepare for
>> TCP_NEW_SYN_RECV support")
>
> When my commit was written (Mon Mar 16 21:06:17 2015 -0700), this
> XT_SOCKET_RESTORESKMARK code was not there yet.
>
>
> The bug was added in commit 01555e74bde5 ("netfilter: xt_socket: add
> XT_SOCKET_RESTORESKMARK flag") which came later (Mon Jun 15 18:40:43
> 2015 -0600)
>
> Please put a correct Fixes: tag, thanks.
>
Sure, I'll update that in v3.
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
prev parent reply other threads:[~2017-09-22 0:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 22:08 [PATCH v2] netfilter: xt_socket: Restore mark from full sockets only Subash Abhinov Kasiviswanathan
2017-09-22 0:01 ` Eric Dumazet
2017-09-22 0:09 ` Subash Abhinov Kasiviswanathan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edf29b9f6c0924c53de486defb8875f8@codeaurora.org \
--to=subashab@codeaurora.org \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).