netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Florian Westphal <fw@strlen.de>, Paolo Abeni <pabeni@redhat.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	netfilter-devel@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	Eric Biggers <ebiggers@kernel.org>
Subject: Re: nft_flowtable.sh selftest failures
Date: Tue, 12 Aug 2025 11:45:11 +0200	[thread overview]
Message-ID: <f1ca1f95-c85c-48a3-beb0-78fff09a5bb2@kernel.org> (raw)
In-Reply-To: <aJsH3c2LcMCJoSeB@strlen.de>

Hi Florian,

(+ Eric in Cc)

On 12/08/2025 11:22, Florian Westphal wrote:
> Paolo Abeni <pabeni@redhat.com> wrote:
>>> I don't see relevant patches landing in the relevant builds, I suspect
>>> the relevant kernel config knob (CONFIG_CRYPTO_SHA1 ?) was always
>>> missing in the ST config, pulled in by NIPA due to some CI setup tweak
>>> possibly changed recently (Jakub could possibly have a better idea/view
>>> about the latter). Could you please have a look?
> 
> Can't reproduce this here.
> 
> Latest net tree:

I don't know if it can help, but did you try to reproduce it on top of
the branch used by the CI?

 https://github.com/linux-netdev/testing/tree/net-next-2025-08-12--06-00

This branch is on top of net-next, where 'net' has been merged, all
pending patches listed on Patchwork have been applied, plus a few
additional patches are there to either fix some temp issues or improve
the CI somehow. Maybe one of these patches caused the removal of
CONFIG_CRYPTO_SHA1.

I guess that's the case, because when looking at the diff [1] when the
issue got introduced, I see some patches [2] from Eric Biggers modifying
some sctp's Kconfig file. They probably cause the issue, but the fix
should be to add CONFIG_CRYPTO_SHA1 in the ST config as mentioned by Paolo.

[1]
https://netdev.bots.linux.dev/static/nipa/branch_deltas/net-next-2025-08-12--03-00.html
[2] https://patchwork.kernel.org/project/netdevbpf/list/?series=990201

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


  reply	other threads:[~2025-08-12  9:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12  7:50 nft_flowtable.sh selftest failures Paolo Abeni
2025-08-12  7:58 ` Paolo Abeni
2025-08-12  9:22   ` Florian Westphal
2025-08-12  9:45     ` Matthieu Baerts [this message]
2025-08-12 10:43       ` Florian Westphal
2025-08-13  4:05         ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1ca1f95-c85c-48a3-beb0-78fff09a5bb2@kernel.org \
    --to=matttbe@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=fw@strlen.de \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).