From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
Harald Welte <laforge@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Unused macro
Date: Sun, 4 Apr 2021 21:52:31 +0200 [thread overview]
Message-ID: <f209f7b0-af4c-e41c-b53e-27028b925978@gmail.com> (raw)
Hi,
I was updating the includes on some manual pages, when I found that a
macro used ARRAY_SIZE() without including a header that defines it.
That surprised me, because it would more than likely result in a compile
error, but of course, the macro wasn't being used:
.../linux$ grep -rn SCTP_CHUNKMAP_IS_ALL_SET
include/uapi/linux/netfilter/xt_sctp.h:80:#define
SCTP_CHUNKMAP_IS_ALL_SET(chunkmap) \
.../linux$
I'd remove it myself and send a patch, but there are probably more
unused macros/functions in the same or related headers, and I see that
many years ago you did some clean up, so maybe you want to clean up even
more, and maybe remove an entire set of functions/macros.
Cheers,
Alex
--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
next reply other threads:[~2021-04-04 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-04 19:52 Alejandro Colomar (man-pages) [this message]
2021-04-04 20:05 ` Unused macro Florian Westphal
2021-04-04 20:44 ` Alejandro Colomar (man-pages)
2021-04-05 21:44 ` Pablo Neira Ayuso
2021-04-06 11:53 ` Alejandro Colomar (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f209f7b0-af4c-e41c-b53e-27028b925978@gmail.com \
--to=alx.manpages@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).