From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D19B6E2B7 for ; Thu, 8 Feb 2024 08:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707382505; cv=none; b=hZTI0zjSF8xbwTxiCcBTAK4Ex3I/+NUmO8SMn1RZHog7nsOcm71LXvFkE5GRo3j8AY1FNzRr1EyEzKiDW6HKpYkOxi6au1AemVKVPq6vUKrKDjJ2tPGvbpIYI3DsZ7HYPf8pNr5Dn2Vdqj5B5jhMdZbs5reEQcmKbOVNZywlmO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707382505; c=relaxed/simple; bh=YDqj+16dWvP7pAZuq/8i/vaNBaTolsWS6I+28VFEPmA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ru2LksWyzGLHKrDy6ksV/xPb2/ISlN4k4gGfuwgNmox9IV8s0kwOdmfaKUb9F0034wIzZgjGcU/NFk8TwDjMDOUWhDFkk4ZpIhDYIbUGjT762IOMWk6wm6rvHfa9FwicyTFMdY3N6+izsezTlRbvjEbVdKq6hMJw3r9TkT9a4vc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AuavEVwN; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AuavEVwN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707382503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YDqj+16dWvP7pAZuq/8i/vaNBaTolsWS6I+28VFEPmA=; b=AuavEVwN5CPohTimd7mwJLQwAYYq+hS0Q8wHIZEokWApukfTeO9FUDdpN3Z5O+wSRNUk7r ld6eVKvUNB6HT/+3OsWssjsM+lXiDFWgSg++LrUGC+Q6RRNDHoTdrfv3Lq8syukWUQoS0N oQ+BEmAbYl6lzLhF6FEAJORsbSrAzBg= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-256-U2OlQCnUO7SMdGfFfcp9_A-1; Thu, 08 Feb 2024 03:55:01 -0500 X-MC-Unique: U2OlQCnUO7SMdGfFfcp9_A-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5115ef6339bso540029e87.1 for ; Thu, 08 Feb 2024 00:55:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707382500; x=1707987300; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YDqj+16dWvP7pAZuq/8i/vaNBaTolsWS6I+28VFEPmA=; b=GPW7KjyDpxDwk1FwfQcyj5RDh9eLSSH4xSOzq1VbFevliHrcGaEUP/9vZfFx2p0x3N /RVqsOYcRJOIh8k3VKH01rgvZOwGTyG/dT21SHWoJ7iW3ocm4uMM0i6vCjzlLVlWDmwu pqIGHoZviV241zKdMH2NtCXqfmNB5GvJSF79jilGGrKUbiI6QjsaASJ1045ZlsPfyMRi Xv9BLdlt6/1IZkfXfb29epP5fmYBPcAJz5SjU9gued1ETWrwUDyAoCQJhmr3lonAKy58 YxlJrGvW9zsmYhvB2lq/BS+YfXnN8fU6Jmeiy0DIsVwN9T84C9WnsguVy1VLjuhf7din 8auw== X-Forwarded-Encrypted: i=1; AJvYcCWXjesE2qeZbLmuO8pfx5tSFh5J1t60bS8uyEORKNgMXeczs2UfpuL+ui4lFYkjeH5UkmVHKK+ORVGuSnDQwSZX2DgIg1MoJW5r5HYvg95n X-Gm-Message-State: AOJu0Yyj1JGamqGjEYgJSMLpWLUvRSEhHb15ezIQHH7vOppiF+s/79rD kch5GsW6YcUeW4HUj4XFLiv+AYQZgjOiRGB/j/m6A7EDE8w+Tbodu+Fo/Pl7O4X6dOOkLeoaqwp gR0h3h1JbMQ0PckpC08hvpL5X388aBeXyffw8ZIwMczgx9YqXj64MBE/hkQylcxfnmA== X-Received: by 2002:a19:2d44:0:b0:511:68e4:63e4 with SMTP id t4-20020a192d44000000b0051168e463e4mr2067080lft.0.1707382499848; Thu, 08 Feb 2024 00:54:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IEkvNjAvY21SHsn5NTxoZvMRX4W3ccgrEXCovZD3BxBrNWmm66NR27I7LYZa8MpEM679Joxmw== X-Received: by 2002:a19:2d44:0:b0:511:68e4:63e4 with SMTP id t4-20020a192d44000000b0051168e463e4mr2067070lft.0.1707382499487; Thu, 08 Feb 2024 00:54:59 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXYo5M8sLPt7smcr960cYOI7bkfgWnq+2HxzWh8Tgz+xWp8kh50LiJdZkSeBQ1AFNQsoP+ohzzDzbbbHtXSupV1Yk6NDu/Ib+T8SVvi6el697zRd7BGvq5SxPAjbCFGwWgU+dSHJeI2Fbz3wbkI7Idcz++K7ag2RgnRJ9Y5PB+lPiAagHd1CV6Dwezx+VDkVFY0yAsKogjjozLDDw== Received: from gerbillo.redhat.com (146-241-238-112.dyn.eolo.it. [146.241.238.112]) by smtp.gmail.com with ESMTPSA id az6-20020a05600c600600b0040fdc645beesm993431wmb.20.2024.02.08.00.54.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 00:54:58 -0800 (PST) Message-ID: Subject: Re: [PATCH net 04/13] netfilter: nft_set_pipapo: remove static in nft_pipapo_get() From: Paolo Abeni To: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org, edumazet@google.com, fw@strlen.de Date: Thu, 08 Feb 2024 09:54:57 +0100 In-Reply-To: <20240207233726.331592-5-pablo@netfilter.org> References: <20240207233726.331592-1-pablo@netfilter.org> <20240207233726.331592-5-pablo@netfilter.org> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2024-02-08 at 00:37 +0100, Pablo Neira Ayuso wrote: > This has slipped through when reducing memory footprint for set > elements, remove it. >=20 > Fixes: 9dad402b89e8 ("netfilter: nf_tables: expose opaque set elementas s= truct nft_elem_priv") (only if v2 is coming) A space is missing in 'elementas' /P