From: David Ahern <dsahern@gmail.com>
To: menglong8.dong@gmail.com, kuba@kernel.org
Cc: rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net,
yoshfuji@linux-ipv6.org, dsahern@kernel.org, pablo@netfilter.org,
kadlec@netfilter.org, fw@strlen.de, imagedong@tencent.com,
edumazet@google.com, alobakin@pm.me, paulb@nvidia.com,
pabeni@redhat.com, talalahmad@google.com, haokexin@gmail.com,
keescook@chromium.org, memxor@gmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
cong.wang@bytedance.com
Subject: Re: [PATCH net-next 4/6] net: ipv4: use kfree_skb_reason() in ip_protocol_deliver_rcu()
Date: Tue, 25 Jan 2022 19:21:12 -0700 [thread overview]
Message-ID: <f493e1e7-0fa0-45f6-4bd6-790492055797@gmail.com> (raw)
In-Reply-To: <20220124131538.1453657-5-imagedong@tencent.com>
On 1/24/22 6:15 AM, menglong8.dong@gmail.com wrote:
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 8942d32c0657..603f77ef2170 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -328,6 +328,8 @@ enum skb_drop_reason {
It would be worthwhile to document the meaning of these as you add them
-- long description of the enum.
> SKB_DROP_REASON_IP_RPFILTER,
> SKB_DROP_REASON_EARLY_DEMUX,
> SKB_DROP_REASON_UNICAST_IN_L2_MULTICAST,
/* xfrm policy check failed */
> + SKB_DROP_REASON_XFRM_POLICY,
/* no support for IP protocol */
> + SKB_DROP_REASON_IP_NOPROTO,
> SKB_DROP_REASON_MAX,
> };
>
If the enum is 1:1 with an SNMP counter, just state that.
next prev parent reply other threads:[~2022-01-26 2:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 13:15 [PATCH net-next 0/6] net: use kfree_skb_reason() for ip/udp packet receive menglong8.dong
2022-01-24 13:15 ` [PATCH net-next 1/6] net: netfilter: use kfree_drop_reason() for NF_DROP menglong8.dong
2022-01-25 23:32 ` Jakub Kicinski
2022-01-26 0:51 ` Pablo Neira Ayuso
2022-01-24 13:15 ` [PATCH net-next 2/6] net: ipv4: use kfree_skb_reason() in ip_rcv_core() menglong8.dong
2022-01-26 2:10 ` David Ahern
2022-01-26 2:26 ` Menglong Dong
2022-01-24 13:15 ` [PATCH net-next 3/6] net: ipv4: use kfree_skb_reason() in ip_rcv_finish_core() menglong8.dong
2022-01-26 2:18 ` David Ahern
2022-01-26 2:36 ` Menglong Dong
2022-01-26 2:57 ` David Ahern
2022-01-26 3:13 ` Menglong Dong
2022-01-24 13:15 ` [PATCH net-next 4/6] net: ipv4: use kfree_skb_reason() in ip_protocol_deliver_rcu() menglong8.dong
2022-01-26 2:21 ` David Ahern [this message]
2022-01-26 2:39 ` Menglong Dong
2022-01-24 13:15 ` [PATCH net-next 5/6] net: udp: use kfree_skb_reason() in udp_queue_rcv_one_skb() menglong8.dong
2022-01-26 2:25 ` David Ahern
2022-01-26 2:43 ` Menglong Dong
2022-01-26 3:04 ` David Ahern
2022-01-26 3:25 ` Jakub Kicinski
2022-01-26 15:28 ` David Ahern
2022-01-24 13:15 ` [PATCH net-next 6/6] net: udp: use kfree_skb_reason() in __udp_queue_rcv_skb() menglong8.dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f493e1e7-0fa0-45f6-4bd6-790492055797@gmail.com \
--to=dsahern@gmail.com \
--cc=alobakin@pm.me \
--cc=cong.wang@bytedance.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=haokexin@gmail.com \
--cc=imagedong@tencent.com \
--cc=kadlec@netfilter.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=memxor@gmail.com \
--cc=menglong8.dong@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=paulb@nvidia.com \
--cc=rostedt@goodmis.org \
--cc=talalahmad@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).