From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D33DCC61D9B for ; Wed, 22 Nov 2023 12:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235039AbjKVMQy (ORCPT ); Wed, 22 Nov 2023 07:16:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230510AbjKVMQx (ORCPT ); Wed, 22 Nov 2023 07:16:53 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DBAA91 for ; Wed, 22 Nov 2023 04:16:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700655402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2YtgfP3pULHSeqQZYgYtqqcGZ7/KXdlepnEAqsrge0w=; b=B0P9hv6A8t/cNxVrdYly47SKRwBRSfAmUFl5I1Y6u4gJIk5vpdivJxPF4ISV5r573VHoPB YRwmWRsnMkdHdLNaXM3ogUrgXwVtrkjhAN/PgsxgXwV2kf+qiPtRu+EgR/AMR44UpYGsnm eOpFKT1MZvy5x4ZZeLaMpUi7KclnvYM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-IZglKU5ZMkKsaldGEEmS4Q-1; Wed, 22 Nov 2023 07:16:41 -0500 X-MC-Unique: IZglKU5ZMkKsaldGEEmS4Q-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-32da8d7a1abso408521f8f.0 for ; Wed, 22 Nov 2023 04:16:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700655400; x=1701260200; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2YtgfP3pULHSeqQZYgYtqqcGZ7/KXdlepnEAqsrge0w=; b=miuZp74c74gkLaJZqI0enx6GYyXJ9wg2WPlp/Aifkb4vK04mCKCeIVaNkh8Asa1JKO 2i0u2GcmiNuwvkb33D552UU/e8zYEoNxxhUyDn3rTPLupT6hANiodFyxurhLxy8u4NT5 J8Y1wcgEirzkVvT4JGAauxatTk0EAUR3mrTrUwAYxKQj7m1Hs8m2FVb9Rcu0uWIOLPG+ CWaylNak7Zu5XquRnkrr5U8+XM4+jOtxGYiqmxJOsMA8mZcDdhv9qoOuVlHhmLQuunSC h0UdcMR0TNojqnfuHdq0w9xzUlEHkQYttif3Og577979m0cid+V+wnA6B5bYg+y6efk1 6Jsg== X-Gm-Message-State: AOJu0YxE0/WzeKWJnOOlO26fW+gpNyiB7NA7WpuUVXwogJsA7CJbjYnP WGP/h3YS8mw4gtTxiaX9Oh11pUJhomI6nT1hMHrODdaHJjdIUlBqkWj7O/VqR5AxOao9tSLbZ/7 Thja4XOPyBqfqb06ElvhLREU8UgMl X-Received: by 2002:a5d:460b:0:b0:332:cde9:5cfc with SMTP id t11-20020a5d460b000000b00332cde95cfcmr1252142wrq.7.1700655400032; Wed, 22 Nov 2023 04:16:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHXDbeKju52EoVTIEmM0nMZRqSKpx/41/T1BiCw9ETNGDoouEjg1nnnq1KmRvbIoXN/j2T/sw== X-Received: by 2002:a5d:460b:0:b0:332:cde9:5cfc with SMTP id t11-20020a5d460b000000b00332cde95cfcmr1252129wrq.7.1700655399714; Wed, 22 Nov 2023 04:16:39 -0800 (PST) Received: from [10.0.0.196] ([37.186.166.196]) by smtp.gmail.com with ESMTPSA id cp33-20020a056000402100b00332c6a52040sm9677775wrb.100.2023.11.22.04.16.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 04:16:39 -0800 (PST) Message-ID: Subject: Re: [PATCH nft v3 1/1] tests/shell: sanitize "handle" in JSON output From: Thomas Haller To: Pablo Neira Ayuso Cc: NetFilter , Phil Sutter , Florian Westphal Date: Wed, 22 Nov 2023 13:16:38 +0100 In-Reply-To: References: <20231121132331.3401846-1-thaller@redhat.com> <8a1e3a2451a770d49a9e130103b8a657e9c23c18.camel@redhat.com> Autocrypt: addr=thaller@redhat.com; prefer-encrypt=mutual; keydata=mQINBFLEazUBEADAszHnys6XWbNHTD4jriYFkKoRcZBBYVFxPdWF5ub9a7zrW7VvzahJPyGgKrOcW5vs0WccrOCTM+wZt63TpHqV1AtWPb4auKPsBJ4ltcU9u9RW6Z/TKv2gA+YoMe6IVnd91qKBCh/SmXzgOqCMv2edDfZfqrcHYFJeSfglw/wR7TJGL5BCcKrUa+zKHwsNCS8rIS7wmGLQGZJwfUFUqzyzz4WNDuL5OYuhoGPd8toecb14a6GYiBpyHi6Ii2EyBmCgSZRp4JprYD3Ryr5o3V3GvuhJuvZvybFAEvYPgUyoX7ZfNCugYCD6z/0CoeDEdAgeCkkLdfTbDBbOLJGOYnbgLQxexxg3bPR5RbDxkiGawJHVkRqy8by6jhhmw1HOgKoAev8yfJJpRQZ60IEvOThIF18ftdsL+wQfXEMQ0VT7F7nFxrQTC6OVKZ+9imlEn9Q5Nk4cdOKPKqweBBJeFOOWI3qARmneF9vbqZ9PL0CUNXFM3wuyeJTwtSxyvPVJQzMADxieUa1AaYrjJzoqgKmBRffwkatoFQqIn4b2nDELPzqNm2qtXz4SERdcSU8AD8fkriLX9TqAcht5M14Sp2bxyoppqEtd3M4GhK4lBlM8YcdTJFT4Imoqb0kGj+jGR7i6LwFqpKM71nmB7YmNfDF1RzMlqH5OFCs/pXdABKQsfwARAQABtCJUaG9tYXMgSGFsbGVyIDx0aGFsbGVyQHJlZGhhdC5jb20+iQJVBBMBCAA/AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgBYhBEnqfGcOCFDnQZUU9inCNm5N/FcoBQJkKn7FBQkVKHqQAAoJECnCNm5N/FcoTx4P/1M9F1O0agPFoFG2eVRvaJnWXDl7hXWueOi442S/Gat0BW1xVJi0mDlvlV0ep09 369EwJz5EgzyXQQiSL33pLOxtPmSB+k5mEDh2C8p6+0hsVTQIsmuDMYIXG 94JnOUjwC28xziMg5ESTYOD0Kum59nnOebG5hkRBEEbT2XLGZhQISvBDfWIQ4tF4zc0603srmXLqi9dKlMK6Kynieorte93s8JU47t71+B11MxGrgA1iPCcD15MSyYDLy6XmM7Q8WmcS8Y0p9JEAJX7BOBfyopeAO8d6Rv2juPjJqnbQh9cneA9YkQxGNE7I7do7zAX81mhPc1JVBn2Nu099LHWgaSmh1FKQUpP8wlzJi7AulRFYvYieg4XjolsmJEpXhv2s4mllRIm68C1SsNRFHx09WmmBjIB1u9Mk/wHZCRJoHUVPLrzBGkspVY204UCE+MMcegkFuIYWxQmYBg+AEq9I0Bn12ILc6UpjCobquvkd7gE7Y1B+nCdJn28nS04WTMpbPWS6zu3NpA6gmCdYNRB08B+VPqXMI7q0yv90ZkBMYoKInS9Ab5C57o8wHBIfEU5+EnPvtaZDI6stGLYAuKI7AmKePxlPZVxV1L36C1EzpmAqjgeRltSQJy5mzSM5OnDbTSMJWPxYX6roHBPMpDUf2FtqAqKlsZHKI/6zmkRKwvnuQINBFLEazUBEADH8k7ECPrqOPPByFUfnWvk5RAIYipZsrNm5oZAF0NVoUKFcYJOJt2yvgSIRB8thVBMYVAlWsSz3FpsbGzdEN23+PNvp8q7DK46im/t1Ld3DqxNoF1iEBhKFgBHvB+TOf6E49+x1dKHbGB91Pn6mYoQ6wLgn3P5lfvnG227Xct6rw+E+Tk+lf8umRNy1SZ/NbTb2N3OSMQlQYqK4MmR93kB3FDSDj/7IkNEqF6BpAIwcr4bpmTkRlMPcOec3KXPsDf45xijhgMqIDGwqYqWYNTXTO/2pEqsHTZC2Rh29QdU0PMANCsboxpSPHtsQI4u+wdkN/BAi40it3MLjhjYayyhOWXnWC2IQBLff5EAon7 4gWZVsR8MCJZvcqMHyPNN+rqXwaaDv6Y9BkrcRO9lB7zC6ueuDqHMFzXOg+ D/1FToMVphmT2gNvJDLw7nTf4mVNHyWiEcQ2sR3TOolSPPjwetoTqE0rhtStN94wlf7yFTe4smnN9rClChQ0XkkTJzjD0Ythi2WpLBl07vYBy9K//YMteGWCwnBeBGPNxdr18X9w/qQxvAYVZyA6huprCO7FcUgzyjV8N9uKnJ5UAnaq3fun5RtRzaBD7Sb4gIy19fsfIwlCWklSi0rP/8gd8E/PQFXb6QkwOEV61AgQDiokUo1WC9yYuqduN9acM6s3VT6QARAQABiQI8BBgBCAAmAhsMFiEESep8Zw4IUOdBlRT2KcI2bk38VygFAmQqfs4FCRUoepkACgkQKcI2bk38VygQQhAAl+a7quouHAZdRbGLrJbNkPeFggliknCBOFzennQd67pH/YHPZQMZNJkiHHpfplESskrbS4BPTIQmwCrWI9+tUoSfOfYTF6b41L3G/UE9wKQznP+/M6FMPe5silbH+Yoj4KLqrTkUyCmEJEV1zKA1Ese5NfY+2IsX/ctclBzNhnZLJgPkKHJL+c9jAHd3IdEWXM40p3LCwMl+887K0djFmchIprU+z4+yfJ0OK7uLYC9h6VDQeJb8iM07pd6san+2rfWZAU2MKQwLUg86u1QPelMjYYH/qwje+Bs0foDYNiSvEj7vz//CqoctxqNqJt3w4Cfz0iUiDSxpO8vh4r0SKVhFJNF71qPTWrjT5Qn7UPEgDzKfxFlrqUN9KayY4j4GS/OszwX0RTlF0+keF67FiOkYvOLxRzsYu9wCswh2loE2JFzTN0+/hoO1XpPb/gxr77gSyY+SL+grEUX5HDa/tTdiNMs3PSvbzht4xe+BIUqygGp5GGui9lDdVHfQOe6lRhMagvALosgLRHp7KtKLZH/ug1XDp0tJ+RB8Zm9CkJ+V7KI4qAC1rflC8fcXSULDYI8tWyn w0SFaex54sbnFUiMVS1BZPlB9yIH5YwMDd8cXvL6lkk9mScg9U9k0OP1cwj7 nzHTx3OrSfP3+UeSVB1Nyr0Kn0PHR5g+hWHjCsbKZAg0EUfpfSwEQALpQiYNk/8mxUS38iMZD0ji7oIDRK78Mp103VUTvyYXJAP4FVXdUWZH+BCgvWZcugi070axPDMQO/f9Cwu3oa65Gn7pLp7tJrM8Ha06OJHTnuPtdgfx4DpJzoPSNCiJmSZzthqtGkLfex+IPuyQiUCgG/dXt7oJ/X1f4Lv21aNCg5c9K6LPeH6BjHGpcXW8Rha9hoCzLXPoD7rUAdqWKegHtSL0+zdU8GVWX82yKqmEGuRJyOSDKO++pIG/25UgXSg/CRNRUkVMGrpfcWFQOkIe78dIO1MIjifC+bMc/laJ1q6xFLFWbAnj6PCpCSi3b8lY6jJxwfooVFFMMw0irvyuH8K/JM3LEP/Dz+MmJb5gBnx21P7F5Sl6eJI0fdEQxmvllrj8HTH5qtC4f4ikAmrSycS5HT1gMntjBbuF8aQX+aI6qEPXS68dcpFNR0J4sUUzpKPabsNfyDkX8jkjYajF5+2iAf9IzwOgDIiZckGXIAuhreBlV+NyJfJrKG7QJbQ6hdK+laSTBdzCn9v/R/ZxWXy9LLkX0kmAxhoa8GPMWqCJXjG405v1ng0FJbxkRAYsijHIOsThM6G56QNBKvW7/gEEoT1+DEGYzqsHVV1gHR9CX3wOyJjcs+bx4RW4WdQLBmUoapNaLkN6zHcWktuh9EL6mo7DZRkTOjvmEsv6bABEBAAG0IlRob21hcyBIYWxsZXIgPHRoYWxsZXJAcmVkaGF0LmNvbT6JAj4EEwECACgFAlH6X0sCGwMFCQPCZwAGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEKHCmQ/SsOFd4QkP/RyUrXafY9o7XIwiS6o2V5mrIZHEQ8M6PdAZDRl3/0FtrQ/cjbFvw3fxfXh IC261AS2f+b0EQr34e5T6XMTqDeZUNJUXLr+9w8FPPn1RQ8wO3wCKGVvplw/f QLVU8JKOKNYQsUnbUSGKwX0he1zGymH0isIiV/X572EgDgrcHHR+z8XIPuIIWfKl7J/xjaqg084kuyAiTw4DEH9RN8XVqTQpVPUh138/nx7GSvZJSS92OvKFaeGXGJ1MUUSKYUyyLQyHD6vxI26S8kEFkinwcn86tF7PblC+AiaS7tFBhW+Bwi641vjyNTsCDwxmhujhlgQhj17qhcG8xPETl2iv8QCOv2TGkvBc1DO2keheVP34bFYQm/vuYQ3heUfyJJWitbHoK9MWj5OUa5AM/uSvogXIL3sQD8K7QSvVTfbodN2WYWPNBVe7pgxifo8u2t3fYWaeySX4pOTGPmJQbr1apdTiTAg+yHpxG6x4FJFs1TsG/PeL81ioBQgIMzBvmqddUrkzAMlxiSBLvJLzPQ4i81F3EBPFvYAdu8z+YwYtRe0HJO2fI4Wi1VWCQ0ed9AmPjzJE+5t3pp6C73pvqthilc9A7EVKL/8aW79+5NCA9I5PQIRaFg9EmcEKGDaZ1pV3ZFtHNpqY7+YdlAkTdP7DPIOLow2rFkD+GksmEsvAxQfe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 (3.50.1-1.fc39) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, 2023-11-22 at 12:22 +0100, Pablo Neira Ayuso wrote: > On Wed, Nov 22, 2023 at 11:44:54AM +0100, Thomas Haller wrote: > > On Wed, 2023-11-22 at 11:36 +0100, Pablo Neira Ayuso wrote: > > > On Tue, Nov 21, 2023 at 02:22:54PM +0100, Thomas Haller wrote: > > > > The "handle" in JSON output is not stable. Sanitize/normalize > > > > to > > > > zero. > > > >=20 > > > > Adjust the sanitize code, and regenerate the .json-nft files. > > >=20 > > > Applied, thanks. > > >=20 > > > I had to adjust a json dump, this diff is not so difficult: > >=20 > > Hi, > >=20 > > Hm. The json dump of the patch was generated. > >=20 > > If you had to "adjust" a dump, does that mean that the output is > > not > > stable? >=20 > I had to adjust json output after my recent series for 4.19 -stable > kernels: >=20 > https://patchwork.ozlabs.org/project/netfilter-devel/list/?series=3D38335= 4 >=20 > (note I splitted a few tests there) >=20 > with your patch output looks stable now here after this patch with > different kernel versions, so all good, thanks! >=20 > > In that case, the .json-nft file should be removed instead (and the > > cause for the difference investigated, fixed, and the dump-re- > > added). >=20 > Agreed, but this different case as explained above. ACK. Thanks. > BTW, I am intentionally missing .json-nft files in my series because > I > am focusing on making progress on 4.19 backports, if you can help me > with with missing .json-nft that I am living on my way, I'd > appreciate. > I promise to make a more careful look on missing .json-nft in the > next > series. Note that on `master` there are - 386 shell tests - 14 tests with .nodump files - 372 tests with .nft dump files (386-14) - 339 tests with .json-nft files - 33 tests that lack .json-nft files (372-339) Meaning, that they are IMO useful already, and there is no immediate hurry to address the missing 33 files. Thomas PS: Reminder: you can identify missing .json-nft files by running `./tools/check-tree.sh`. You can generate missing files either via $ DUMPGEN=3Dall ./tests/shell/run-tests.sh tests/shell/testcases/cache/00= 10_implicit_chain_0 or just $ touch tests/shell/testcases/cache/dumps/0010_implicit_chain_0.json-nft $ ./tests/shell/run-tests.sh tests/shell/testcases/cache/0010_implicit_ch= ain_0 -g