From: Thomas Haller <thaller@redhat.com>
To: Jan Engelhardt <jengelh@inai.de>
Cc: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [nft PATCH] src: use reentrant getprotobyname_r()/getprotobynumber_r()/getservbyport_r()
Date: Fri, 11 Aug 2023 13:28:37 +0200 [thread overview]
Message-ID: <fa007805b7c61958043e94defe340e41896b17ad.camel@redhat.com> (raw)
In-Reply-To: <o4o37q01-r4s6-o009-379n-rsr0n79817r0@vanv.qr>
On Thu, 2023-08-10 at 23:48 +0200, Jan Engelhardt wrote:
>
> On Thursday 2023-08-10 14:30, Thomas Haller wrote:
> >
> > +bool nft_getprotobyname(const char *name, uint8_t *out_proto);
>
> Knowing that proto can only be uint8, why not make this work like
> getc() where the return type is a type with a larger range?
>
> int nft_getprotobyname(const char *name)
> {
> workworkwork();
> if (error)
> return -1;
> return workresult;
> }
>
Hi,
I will do (in version2).
Thanks!
Thomas
next prev parent reply other threads:[~2023-08-11 11:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 12:30 [nft PATCH] src: use reentrant getprotobyname_r()/getprotobynumber_r()/getservbyport_r() Thomas Haller
2023-08-10 21:48 ` Jan Engelhardt
2023-08-11 11:28 ` Thomas Haller [this message]
2023-08-11 12:20 ` Pablo Neira Ayuso
2023-08-11 12:58 ` Thomas Haller
2023-08-16 16:16 ` Pablo Neira Ayuso
2023-08-18 9:18 ` [nft PATCH v2] " Thomas Haller
2023-08-18 9:57 ` Pablo Neira Ayuso
2023-08-18 14:14 ` Thomas Haller
2023-08-18 16:10 ` Pablo Neira Ayuso
2023-08-18 16:23 ` Pablo Neira Ayuso
2023-08-18 17:38 ` Thomas Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa007805b7c61958043e94defe340e41896b17ad.camel@redhat.com \
--to=thaller@redhat.com \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).