RE: [PATCH net] netfilter: nf_conncount: fix wrong variable type

[wangyunjian <wangyunjian@huawei.com>]

> -----Original Message-----
> From: Florian Westphal [mailto:fw@strlen.de]
> Sent: Thursday, May 30, 2024 3:52 PM
> To: wangyunjian <wangyunjian@huawei.com>
> Cc: Florian Westphal <fw@strlen.de>; netfilter-devel@vger.kernel.org;
> pablo@netfilter.org; kadlec@netfilter.org; kuba@kernel.org;
> davem@davemloft.net; coreteam@netfilter.org; xudingke
> <xudingke@huawei.com>
> Subject: Re: [PATCH net] netfilter: nf_conncount: fix wrong variable type
> 
> wangyunjian <wangyunjian@huawei.com> wrote:
> > > -----Original Message-----
> > > From: Florian Westphal [mailto:fw@strlen.de]
> > > Sent: Wednesday, May 29, 2024 8:03 PM
> > > To: wangyunjian <wangyunjian@huawei.com>
> > > Cc: netfilter-devel@vger.kernel.org; pablo@netfilter.org;
> kadlec@netfilter.org;
> > > kuba@kernel.org; davem@davemloft.net; coreteam@netfilter.org;
> xudingke
> > > <xudingke@huawei.com>
> > > Subject: Re: [PATCH net] netfilter: nf_conncount: fix wrong variable type
> > >
> > > Yunjian Wang <wangyunjian@huawei.com> wrote:
> > > > 'keylen' is supposed to be unsigned int, not u8, so fix it.
> > >
> > > Its limited to 5, so u8 works fine.
> >
> > Currently, it does not affect the functionality. The main issue is that code
> > checks will report a warning: implicit narrowing conversion from type
> > 'unsigned int' to small type 'u8'.
> 
> Then please quote the exact warning in the commit message and remove the
> u8 temporary variable in favor of data->keylen.

OK, I will update it. This is not a bugfix, only considered for net-next?

Thanks.