From: "Pēteris Kļaviņš" <klavins@netspace.net.au>
To: netfilter-devel@vger.kernel.org
Subject: Re: [RFC] netfilter: Rename ipt_ECN.h to ipt_ecn_target.h (and similar) to avoid file name clash
Date: Sat, 16 Aug 2008 17:32:18 +0200 [thread overview]
Message-ID: <g86rul$1gb$1@ger.gmane.org> (raw)
In-Reply-To: <alpine.LNX.1.10.0808160958570.30044@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
>> include/linux/netfilter/xt_CONNMARK.h => xt_connmark_target.h
> [...]
>
> As I see it, this will already be addressed by merging complementary
> code into one source file (e.g. MARK, mark, CONNMARK, connmark
> all into a big new xt_mark.c), to reduce (a) amount of files
> and (b) build time.
>
> This has been touched before at
> http://marc.info/?l=netfilter-devel&m=121148631320895&w=2
> I welcome that idea, but have yet been holding off sending patches
> on that because these code-moving changes would possibly generate
> a lot of .rej noise while I am still having other patches in my
> queue.
Thanks very much for the heads-up on the pending code simplification, of
course it makes sense to rename files as part of that work.
I'll clone git://git.netfilter.org/iptables.git regularly, watching for
the file name clashes to go away, and I'll only nag on this list if I
think that it's been forgotten, I hope that's OK.
--
Peter Klavins
next prev parent reply other threads:[~2008-08-16 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 22:03 [RFC] netfilter: Rename ipt_ECN.h to ipt_ecn_target.h (and similar) to avoid file name clash Pēteris Kļaviņš
2008-08-16 14:04 ` Jan Engelhardt
2008-08-16 15:32 ` Pēteris Kļaviņš [this message]
2008-08-16 19:14 ` Jozsef Kadlecsik
2008-08-16 19:22 ` Jan Engelhardt
2008-08-16 19:52 ` Jozsef Kadlecsik
2008-08-16 20:19 ` Pēteris Kļaviņš
2008-08-17 22:04 ` Jozsef Kadlecsik
2008-08-17 22:18 ` Jan Engelhardt
2008-08-18 11:17 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='g86rul$1gb$1@ger.gmane.org' \
--to=klavins@netspace.net.au \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox