netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Changli Gao <xiaosuo@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Patrick McHardy <kaber@trash.net>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] nfnetlink_queue: use hash table to speed up entry finding.
Date: Tue, 13 Apr 2010 21:02:49 +0800	[thread overview]
Message-ID: <h2h412e6f7f1004130602sbeba6466w198a600253ad447@mail.gmail.com> (raw)
In-Reply-To: <1271162669.16881.301.camel@edumazet-laptop>

On Tue, Apr 13, 2010 at 8:44 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le mardi 13 avril 2010 à 19:06 +0800, Changli Gao a écrit :
>
> Thats theory. And for sparse arrays, that pro might be true.
> In your case, you prealloc all the array, using more ram than vmalloc...
>
> In practice, x86 cpu can access vmalloced() data much faster then
> flex_array_managed data (take a look at all the expensive divides in
> flex code... :'( )
>
> If vmalloc() happens to be slow, it can trivially be extended to use
> huge pages too. It will happen one day, when/if necessary.
>

The current flex_array isn't optimized well. If it is well optimized,
will it be faster than vmalloc()?

-- 
Regards,
Changli Gao(xiaosuo@gmail.com)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-04-13 13:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-09  4:13 [PATCH 3/3] nfnetlink_queue: use hash table to speed up entry finding Changli Gao
2010-04-09  4:50 ` Eric Dumazet
2010-04-13 10:09 ` Patrick McHardy
2010-04-13 11:06   ` Changli Gao
2010-04-13 12:44     ` Eric Dumazet
2010-04-13 13:02       ` Changli Gao [this message]
2010-04-13 13:09       ` Changli Gao
2010-04-13 13:23         ` Eric Dumazet
2010-04-13 13:25           ` Patrick McHardy
2010-04-15  6:53             ` Changli Gao
2010-04-15  8:23               ` Eric Dumazet
2010-04-15  8:30                 ` Changli Gao
2010-04-15 10:36               ` Patrick McHardy
2010-04-15 14:35                 ` Changli Gao
2010-04-15 14:40                   ` Patrick McHardy
2010-04-15 14:46                     ` Patrick McHardy
2010-04-15 15:01                       ` Changli Gao
2010-04-15 15:05                         ` Patrick McHardy
2010-04-15 15:11                           ` Changli Gao
2010-04-15 15:35                             ` Patrick McHardy
2010-04-16 13:50                               ` Changli Gao
2010-04-16 15:30                                 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=h2h412e6f7f1004130602sbeba6466w198a600253ad447@mail.gmail.com \
    --to=xiaosuo@gmail.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).