[PATCH] netfilter: LED: fix man page fragment inclusion

[PATCH] netfilter: LED: fix man page fragment inclusion

[Sergei Zhirikov]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

The man page fragment of the recently added LED target does not get included into iptables.8 and ip6tables.8 produced during build. This patch fixes that.

[-- Attachment #2: LED-man.patch --]
[-- Type: text/plain, Size: 559 bytes --]

diff --git a/extensions/libxt_LED.c b/extensions/libxt_LED.c
index af0e091..9a08e89 100644
--- a/extensions/libxt_LED.c
+++ b/extensions/libxt_LED.c
@@ -137,7 +137,7 @@ static void LED_save(const void *ip, const struct xt_entry_target *target)
 static struct xtables_target led_tg_reg = {
 	.version       = XTABLES_VERSION,
 	.name          = "LED",
-	.family        = PF_UNSPEC,
+	.family        = NFPROTO_UNSPEC,
 	.revision      = 0,
 	.size          = XT_ALIGN(sizeof(struct xt_led_info)),
 	.userspacesize = offsetof(struct xt_led_info, internal_data),

Re: [PATCH] netfilter: LED: fix man page fragment inclusion

[Patrick McHardy]

Sergei Zhirikov wrote:
> The man page fragment of the recently added LED target does not get 
> included into iptables.8 and ip6tables.8 produced during build. This 
> patch fixes that.

You seem to have attached a different patch, please resend.

Re: [PATCH] netfilter: LED: fix man page fragment inclusion

[Sergei Zhirikov]

No, it was the correct patch. The Makefile looks for NFPROTO_UNSPEC in the source file in order to decide whether the manpage fragment should be included.

--- On Fri, 7/2/10, Patrick McHardy <kaber@trash.net> wrote:

> From: Patrick McHardy <kaber@trash.net>
> Subject: Re: [PATCH] netfilter: LED: fix man page fragment inclusion
> To: "Sergei Zhirikov" <sfzhi@yahoo.com>
> Cc: netfilter-devel@vger.kernel.org
> Date: Friday, July 2, 2010, 9:44 AM
> Sergei Zhirikov wrote:
> > The man page fragment of the recently added LED target
> does not get included into iptables.8 and ip6tables.8
> produced during build. This patch fixes that.
> 
> You seem to have attached a different patch, please
> resend.
> 

Re: [PATCH] netfilter: LED: fix man page fragment inclusion

[Patrick McHardy]

Sergei Zhirikov wrote:
> No, it was the correct patch. The Makefile looks for NFPROTO_UNSPEC in the source file in order to decide whether the manpage fragment should be included.
>   

I see, thanks. Please make a formal submission, including a
Signed-off-by: line.