From: Changli Gao <xiaosuo@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Eric Dumazet <eric.dumazet@gmail.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] nfnetlink_queue: use hash table to speed up entry finding.
Date: Thu, 15 Apr 2010 23:01:41 +0800 [thread overview]
Message-ID: <j2w412e6f7f1004150801m66503602wbd0296c09aa45e90@mail.gmail.com> (raw)
In-Reply-To: <4BC726B4.1030003@trash.net>
On Thu, Apr 15, 2010 at 10:46 PM, Patrick McHardy <kaber@trash.net> wrote:
> Patrick McHardy wrote:
>>
>> That should be easily fixable. For the lookup we can add a reference
>> counter so we don't need the rcu read side critical section.
>
> Actually we don't even need that, since we're holding nfnl_mutex the
> instance can't go away.
>
I don't think so. a netlink queue instance maybe destroyed by
nfqnl_rcv_nl_event(). And the function is called by netlink directly
without nfnl_mutex.
--
Regards，
Changli Gao(xiaosuo@gmail.com)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-04-15 15:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 4:13 [PATCH 3/3] nfnetlink_queue: use hash table to speed up entry finding Changli Gao
2010-04-09 4:50 ` Eric Dumazet
2010-04-13 10:09 ` Patrick McHardy
2010-04-13 11:06 ` Changli Gao
2010-04-13 12:44 ` Eric Dumazet
2010-04-13 13:02 ` Changli Gao
2010-04-13 13:09 ` Changli Gao
2010-04-13 13:23 ` Eric Dumazet
2010-04-13 13:25 ` Patrick McHardy
2010-04-15 6:53 ` Changli Gao
2010-04-15 8:23 ` Eric Dumazet
2010-04-15 8:30 ` Changli Gao
2010-04-15 10:36 ` Patrick McHardy
2010-04-15 14:35 ` Changli Gao
2010-04-15 14:40 ` Patrick McHardy
2010-04-15 14:46 ` Patrick McHardy
2010-04-15 15:01 ` Changli Gao [this message]
2010-04-15 15:05 ` Patrick McHardy
2010-04-15 15:11 ` Changli Gao
2010-04-15 15:35 ` Patrick McHardy
2010-04-16 13:50 ` Changli Gao
2010-04-16 15:30 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=j2w412e6f7f1004150801m66503602wbd0296c09aa45e90@mail.gmail.com \
--to=xiaosuo@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).