From: ebiederm@xmission.com (Eric W. Biederman)
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: wli@movementarian.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] Update jhash.h with the new version of Jenkins' hash
Date: Thu, 12 Feb 2009 11:58:04 -0800 [thread overview]
Message-ID: <m1wsbvctrn.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <alpine.DEB.2.00.0902121006440.18739@blackhole.kfki.hu> (Jozsef Kadlecsik's message of "Thu\, 12 Feb 2009 10\:11\:43 +0100 \(CET\)")
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> writes:
> On Wed, 11 Feb 2009, wli@movementarian.org wrote:
>
>> On Wed, Feb 11, 2009 at 11:19:20AM +0100, Jozsef Kadlecsik wrote:
>> > /* The golden ration: an arbitrary value */
>> > -#define JHASH_GOLDEN_RATIO 0x9e3779b9
>> > +#define JHASH_GOLDEN_RATIO 0xdeadbeef
>>
0xdeadbeef is a really bad choice of an arbitrary value. It is
already used in multiple places. Only a few of which are currently
listed in linux/poison.h and if I happened to see that number in a
debug trace having to sort through all of the possible sources looks
like a major pain.
I don't really care what we call it but somehow 0xdeadbeef strikes me
as wrong and something that will make debugging harder.
Eric
next prev parent reply other threads:[~2009-02-12 19:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 10:19 [PATCH] Update jhash.h with the new version of Jenkins' hash Jozsef Kadlecsik
2009-02-11 20:19 ` Michał Mirosław
2009-02-11 22:50 ` Jozsef Kadlecsik
2009-02-11 23:23 ` Michał Mirosław
2009-02-12 0:12 ` wli
2009-02-12 0:29 ` David Miller
2009-02-12 0:41 ` Jan Engelhardt
2009-02-12 9:05 ` Jarek Poplawski
2009-02-12 9:55 ` Jarek Poplawski
2009-02-12 9:11 ` Jozsef Kadlecsik
2009-02-12 9:16 ` Patrick McHardy
2009-02-12 9:41 ` Jozsef Kadlecsik
2009-02-12 13:46 ` Kyle Moffett
2009-02-17 17:13 ` Jozsef Kadlecsik
2009-02-18 5:11 ` Rusty Russell
2009-02-18 11:50 ` Ilpo Järvinen
2009-02-12 19:58 ` Eric W. Biederman [this message]
2009-02-12 2:58 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2009-02-10 19:40 Jozsef Kadlecsik
2009-02-10 21:19 ` Scott Feldman
2009-02-10 22:03 ` Jozsef Kadlecsik
2009-02-11 1:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1wsbvctrn.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=wli@movementarian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).