From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH] Update jhash.h with the new version of Jenkins' hash Date: Thu, 12 Feb 2009 11:58:04 -0800 Message-ID: References: <20090212001223.GA5757@movementarian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: wli@movementarian.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Rusty Russell To: Jozsef Kadlecsik Return-path: Received: from out01.mta.xmission.com ([166.70.13.231]:33173 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbZBLT6B (ORCPT ); Thu, 12 Feb 2009 14:58:01 -0500 In-Reply-To: (Jozsef Kadlecsik's message of "Thu\, 12 Feb 2009 10\:11\:43 +0100 \(CET\)") Sender: netfilter-devel-owner@vger.kernel.org List-ID: Jozsef Kadlecsik writes: > On Wed, 11 Feb 2009, wli@movementarian.org wrote: > >> On Wed, Feb 11, 2009 at 11:19:20AM +0100, Jozsef Kadlecsik wrote: >> > /* The golden ration: an arbitrary value */ >> > -#define JHASH_GOLDEN_RATIO 0x9e3779b9 >> > +#define JHASH_GOLDEN_RATIO 0xdeadbeef >> 0xdeadbeef is a really bad choice of an arbitrary value. It is already used in multiple places. Only a few of which are currently listed in linux/poison.h and if I happened to see that number in a debug trace having to sort through all of the possible sources looks like a major pain. I don't really care what we call it but somehow 0xdeadbeef strikes me as wrong and something that will make debugging harder. Eric