From: Donald Hunter <donald.hunter@gmail.com>
To: "Remy D. Farley" <one-d-wide@protonmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>, Phil Sutter <phil@nwl.cc>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCH v5 1/6] doc/netlink: netlink-raw: Add max check
Date: Fri, 21 Nov 2025 10:03:37 +0000 [thread overview]
Message-ID: <m2wm3j4s92.fsf@gmail.com> (raw)
In-Reply-To: <20251120151754.1111675-2-one-d-wide@protonmail.com>
"Remy D. Farley" <one-d-wide@protonmail.com> writes:
> Suggested-by: Donald Hunter <donald.hunter@gmail.com>
> Signed-off-by: Remy D. Farley <one-d-wide@protonmail.com>
Missing description, therwise, LGTM.
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
> ---
> Documentation/netlink/netlink-raw.yaml | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/netlink/netlink-raw.yaml b/Documentation/netlink/netlink-raw.yaml
> index 0166a7e4a..dd98dda55 100644
> --- a/Documentation/netlink/netlink-raw.yaml
> +++ b/Documentation/netlink/netlink-raw.yaml
> @@ -19,6 +19,12 @@ $defs:
> type: [ string, integer ]
> pattern: ^[0-9A-Za-z_-]+( - 1)?$
> minimum: 0
> + len-or-limit:
> + # literal int, const name, or limit based on fixed-width type
> + # e.g. u8-min, u16-max, etc.
> + type: [ string, integer ]
> + pattern: ^[0-9A-Za-z_-]+$
> + minimum: 0
>
> # Schema for specs
> title: Protocol
> @@ -270,7 +276,10 @@ properties:
> type: string
> min:
> description: Min value for an integer attribute.
> - type: integer
> + $ref: '#/$defs/len-or-limit'
> + max:
> + description: Max value for an integer attribute.
> + $ref: '#/$defs/len-or-limit'
> min-len:
> description: Min length for a binary attribute.
> $ref: '#/$defs/len-or-define'
next prev parent reply other threads:[~2025-11-21 11:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 15:18 [PATCH v5 0/6] doc/netlink: Expand nftables specification Remy D. Farley
2025-11-20 15:18 ` [PATCH v5 1/6] doc/netlink: netlink-raw: Add max check Remy D. Farley
2025-11-21 10:03 ` Donald Hunter [this message]
2025-11-20 15:19 ` [PATCH v5 2/6] doc/netlink: nftables: Add definitions Remy D. Farley
2025-11-21 11:33 ` Donald Hunter
2025-11-20 15:19 ` [PATCH v5 3/6] doc/netlink: nftables: Update attribute sets Remy D. Farley
2025-11-20 15:19 ` [PATCH v5 4/6] doc/netlink: nftables: Add sub-messages Remy D. Farley
2025-11-21 11:40 ` Donald Hunter
2025-11-20 15:19 ` [PATCH v5 5/6] doc/netlink: nftables: Add getcompat operation Remy D. Farley
2025-11-20 15:19 ` [PATCH v5 6/6] doc/netlink: nftables: Fill out operation attributes Remy D. Farley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wm3j4s92.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=one-d-wide@protonmail.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).