From: Wei Han <lailitty@foxmail.com>
To: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lailitty@foxmail.com, linux-staging@lists.linux.dev
Subject: [PATCH] netfilter: xt_esp: add support for ESP match in NAT Traversal
Date: Thu, 23 Jun 2022 20:42:48 +0800 [thread overview]
Message-ID: <tencent_DDE91CB7412D427A442DB4362364DC04F20A@qq.com> (raw)
when the ESP packets traversing Network Address Translators,
which are encapsulated and decapsulated inside UDP packets,
so we need to get ESP data in UDP.
Signed-off-by: Wei Han <lailitty@foxmail.com>
---
net/netfilter/xt_esp.c | 54 +++++++++++++++++++++++++++++++++++-------
1 file changed, 45 insertions(+), 9 deletions(-)
diff --git a/net/netfilter/xt_esp.c b/net/netfilter/xt_esp.c
index 2a1c0ad0ff07..c3feb79a830a 100644
--- a/net/netfilter/xt_esp.c
+++ b/net/netfilter/xt_esp.c
@@ -8,12 +8,14 @@
#include <linux/skbuff.h>
#include <linux/in.h>
#include <linux/ip.h>
+#include <linux/ipv6.h>
#include <linux/netfilter/xt_esp.h>
#include <linux/netfilter/x_tables.h>
#include <linux/netfilter_ipv4/ip_tables.h>
#include <linux/netfilter_ipv6/ip6_tables.h>
+#include <net/ip.h>
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Yon Uriarte <yon@astaro.de>");
@@ -39,17 +41,53 @@ static bool esp_mt(const struct sk_buff *skb, struct xt_action_param *par)
struct ip_esp_hdr _esp;
const struct xt_esp *espinfo = par->matchinfo;
+ const struct iphdr *iph = NULL;
+ const struct ipv6hdr *ip6h = NULL;
+ const struct udphdr *udph = NULL;
+ struct udphdr _udph;
+ int proto = -1;
+
/* Must not be a fragment. */
if (par->fragoff != 0)
return false;
- eh = skb_header_pointer(skb, par->thoff, sizeof(_esp), &_esp);
- if (eh == NULL) {
- /* We've been asked to examine this packet, and we
- * can't. Hence, no choice but to drop.
- */
- pr_debug("Dropping evil ESP tinygram.\n");
- par->hotdrop = true;
+ if (xt_family(par) == NFPROTO_IPV6) {
+ ip6h = ipv6_hdr(skb);
+ if (!ip6h)
+ return false;
+ proto = ip6h->nexthdr;
+ } else {
+ iph = ip_hdr(skb);
+ if (!iph)
+ return false;
+ proto = iph->protocol;
+ }
+
+ if (proto == IPPROTO_UDP) {
+ //for NAT-T
+ udph = skb_header_pointer(skb, par->thoff, sizeof(_udph), &_udph);
+ if (udph && (udph->source == htons(4500) || udph->dest == htons(4500))) {
+ /* Not deal with above data it don't conflict with SPI
+ * 1.IKE Header Format for Port 4500(Non-ESP Marker 0x00000000)
+ * 2.NAT-Keepalive Packet Format(0xFF)
+ */
+ eh = (struct ip_esp_hdr *)((char *)udph + sizeof(struct udphdr));
+ } else {
+ return false;
+ }
+ } else if (proto == IPPROTO_ESP) {
+ //not NAT-T
+ eh = skb_header_pointer(skb, par->thoff, sizeof(_esp), &_esp);
+ if (!eh) {
+ /* We've been asked to examine this packet, and we
+ * can't. Hence, no choice but to drop.
+ */
+ pr_debug("Dropping evil ESP tinygram.\n");
+ par->hotdrop = true;
+ return false;
+ }
+ } else {
+ //not esp data
return false;
}
@@ -76,7 +114,6 @@ static struct xt_match esp_mt_reg[] __read_mostly = {
.checkentry = esp_mt_check,
.match = esp_mt,
.matchsize = sizeof(struct xt_esp),
- .proto = IPPROTO_ESP,
.me = THIS_MODULE,
},
{
@@ -85,7 +122,6 @@ static struct xt_match esp_mt_reg[] __read_mostly = {
.checkentry = esp_mt_check,
.match = esp_mt,
.matchsize = sizeof(struct xt_esp),
- .proto = IPPROTO_ESP,
.me = THIS_MODULE,
},
};
--
2.17.1
next reply other threads:[~2022-06-23 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 12:42 Wei Han [this message]
2022-06-23 19:36 ` [PATCH] netfilter: xt_esp: add support for ESP match in NAT Traversal Pablo Neira Ayuso
2022-06-24 12:05 ` Wei Han
2022-06-27 17:22 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_DDE91CB7412D427A442DB4362364DC04F20A@qq.com \
--to=lailitty@foxmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).