From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dong Fang Subject: [PATCH] netfilter: avoid array overflow in nf_register_hook Date: Fri, 23 Aug 2013 23:07:31 -0400 Message-ID: <1377313651-16096-1-git-send-email-yp.fangdong@gmail.com> Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=UoEMEY+jpD7Qvi55coWwYzUW1T95EInBrputZLbehQs=; b=QrV0FsJndiTlOtqcGjZxjPbtd7p62e0+Ccru5DWcHq2oqKYNmvhMLfYf3o1AuQC6Bh oCbR5Jz7hPs16y4P5HgO/k2rFHqF0JM7ha+7FFSiGfk21oay6a+dCMozbOLYXflBn/X4 z/cH4z2Cbrq1qfjAxaD2lz/m3cFNwLmxRPWJ7dmZyHjL+etSzwhpWfALlFGvkdK7IxfQ CYi/woaQAnGASUw2txiNvX8mHs+bo45OkdNwD9YFdliYyz7JheWQ2ZouhjOYvT1uqJRP pTiLKINYN5eQmkaFkTmkWICSHIT3pd+Nd17fnfaEuEWo/PQS1l6z8QProzI7+nXeucZ6 utzw== Sender: netfilter-devel-owner@vger.kernel.org List-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu, davem@davemloft.net, yp.fangdong@gmail.com Cc: netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org This patch fix the array overflow in nf_register_hook function Signed-off-by: Dong Fang --- net/netfilter/core.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/net/netfilter/core.c b/net/netfilter/core.c index 2217363..819eee1 100644 --- a/net/netfilter/core.c +++ b/net/netfilter/core.c @@ -68,8 +68,11 @@ static DEFINE_MUTEX(nf_hook_mutex); int nf_register_hook(struct nf_hook_ops *reg) { struct nf_hook_ops *elem; - int err; + int err = -EINVAL; + if (reg->pf >= NFPROTO_NUMPROTO || reg->hooknum >= NF_MAX_HOOKS) + return err; + err = mutex_lock_interruptible(&nf_hook_mutex); if (err < 0) return err; -- 1.7.1