Re: Call for testing: patch-o-matic-ng

[Harald Welte <laforge@netfilter.org>]

[-- Attachment #1: Type: text/plain, Size: 2037 bytes --]

On Tue, Dec 23, 2003 at 02:13:15PM +0100, Gaël Le Mignot wrote:
> I've tested pom-ng on 2.6.0  with USAGI patch, the patch-o-matic seems
> to work, but the kernel doesn't compile (I put nearly all patches, and
> select M in the kernel config wherever it was possible):
> 
>   CC      net/core/netfilter.o
> net/core/netfilter.c: In function `nf_log_register':
> net/core/netfilter.c:760: warning: implicit declaration of function `br_write_lock_bh'
> net/core/netfilter.c:760: error: `BR_NETPROTO_LOCK' undeclared (first use in this function)
> net/core/netfilter.c:760: error: (Each undeclared identifier is reported only once
> net/core/netfilter.c:760: error: for each function it appears in.)
> net/core/netfilter.c:765: warning: implicit declaration of function `br_write_unlock_bh'
> net/core/netfilter.c: In function `nf_log_unregister':
> net/core/netfilter.c:770: error: `BR_NETPROTO_LOCK' undeclared (first use in this function)
> make[3]: *** [net/core/netfilter.o] Error 1
> 
> 
> I think maybe some patches doesn't work with 2.6, would it possible to
> add a way to select patch that works with 2.6 ? like ./runme extra-2.6
> or such ?

yes, indeed.  There are numerous patches that would not work in the
2.6.x kernels.  They have yet to be identified.  Once they are
identified, we can put a special "requires" tag into the 'info' file of
those patches.

This way the 2.4 only patches would only be offered if you have a 2.4.x
kernel source (and vice-versa).

You could help us in finding out which patches compile and which ones
don't.

> -- 
> Gael Le Mignot "Kilobug" - kilobug@nerim.net - http://kilobug.free.fr

-- 
- Harald Welte <laforge@netfilter.org>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]