Re: Please, see this firewall and say (have pity...:)

[Patrick Leslie Polzer <leslie.polzer@gmx.net>]

On Thu, 10 Jun 2004 01:36:28 -0300
"Ricardo C" <racham@hotmail.com> wrote:

> You could give me your opinions????
I don't have enough time to comment on all of this, but using loops increases
readability, so

$IPTABLES -t nat -A PREROUTING -p tcp -d $INET_IP --dport 4661 -j DNAT --to-destination 192.168.111.2:4661
$IPTABLES -t nat -A PREROUTING -p tcp -d $INET_IP --dport 4662 -j DNAT --to-destination 192.168.111.2:4662
$IPTABLES -t nat -A PREROUTING -p tcp -d $INET_IP --dport 4711 -j DNAT --to-destination 192.168.111.2:4711
$IPTABLES -t nat -A PREROUTING -p UDP -d $INET_IP --dport 4000 -j DNAT --to-destination 192.168.111.2:4000
$IPTABLES -t nat -A PREROUTING -p UDP -d $INET_IP --dport 4665 -j DNAT --to-destination 192.168.111.2:4665
$IPTABLES -t nat -A PREROUTING -p UDP -d $INET_IP --dport 4672 -j DNAT --to-destination 192.168.111.2:4672

should become

for port in 4661 4662 4711 4000 4665 4672; do
    $IPTABLES -t nat -A PREROUTING -p tcp -d $INET_IP --dport $port -j DNAT
        --to-destination 192.168.111.2
done

Apply this to other apt locations in your firewall script as well.


Kind regards,

Leslie