From: David Miller <davem@davemloft.net>
To: rdunlap@xenotime.net
Cc: eric.dumazet@gmail.com, zbr@ioremap.net, kdakhane@gmail.com,
netdev@vger.kernel.org, netfilter@vger.kernel.org
Subject: Re: [PATCH] tcp: documents timewait refcnt tricks
Date: Tue, 08 Dec 2009 20:20:19 -0800 (PST) [thread overview]
Message-ID: <20091208.202019.169120898.davem@davemloft.net> (raw)
In-Reply-To: <4B1D2822.5030704@xenotime.net>
From: Randy Dunlap <rdunlap@xenotime.net>
Date: Mon, 07 Dec 2009 08:06:58 -0800
> Eric Dumazet wrote:
>> Evgeniy Polyakov a écrit :
>> [PATCH] tcp: documents timewait refcnt tricks
>>
>> Adds kerneldoc for inet_twsk_unhash() & inet_twsk_bind_unhash().
>>
>> Suggested-by: Evgeniy Polyakov <zbr@ioremap.net>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
...
>> + * unhash a timewait socket from established hash, if hashed.
>> + * ehash lock must be hold by caller.
>
> held
>
...
>> + * unhash a timewait socket from bind hash, if hashed.
>> + * bind hash lock must be hold by caller.
>
> held
I've applied the patch with Randy's corrections added.
next prev parent reply other threads:[~2009-12-09 4:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 2:02 soft lockup in inet_csk_get_port kapil dakhane
2009-12-01 6:10 ` Eric Dumazet
2009-12-01 15:00 ` [PATCH] tcp: Fix a connect() race with timewait sockets Eric Dumazet
2009-12-02 8:59 ` David Miller
2009-12-02 9:23 ` Eric Dumazet
2009-12-02 10:33 ` Eric Dumazet
2009-12-02 11:32 ` Evgeniy Polyakov
2009-12-02 19:18 ` kapil dakhane
2009-12-03 2:43 ` kapil dakhane
2009-12-03 10:49 ` [PATCH] tcp: fix a timewait refcnt race Eric Dumazet
2009-12-04 0:19 ` David Miller
2009-12-04 3:20 ` kapil dakhane
2009-12-04 6:29 ` Eric Dumazet
2009-12-04 6:39 ` David Miller
2009-12-02 15:08 ` [PATCH net-next-2.6] tcp: connect() race with timewait reuse Eric Dumazet
2009-12-02 22:15 ` Evgeniy Polyakov
2009-12-03 6:44 ` Eric Dumazet
2009-12-03 8:31 ` Eric Dumazet
2009-12-03 23:22 ` Evgeniy Polyakov
2009-12-04 0:18 ` David Miller
2009-12-02 16:05 ` [PATCH] tcp: Fix a connect() race with timewait sockets Ashwani Wason
2009-12-03 6:38 ` David Miller
2009-12-04 13:45 ` [PATCH 0/2] tcp: Fix connect() races " Eric Dumazet
2009-12-04 13:46 ` [PATCH 1/2] tcp: Fix a connect() race " Eric Dumazet
2009-12-05 21:21 ` Evgeniy Polyakov
2009-12-07 9:59 ` [PATCH] tcp: documents timewait refcnt tricks Eric Dumazet
2009-12-07 16:06 ` Randy Dunlap
2009-12-09 4:20 ` David Miller [this message]
2009-12-09 4:18 ` [PATCH 1/2] tcp: Fix a connect() race with timewait sockets David Miller
2009-12-04 13:47 ` [PATCH 2/2] " Eric Dumazet
2009-12-09 4:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091208.202019.169120898.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kdakhane@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).