From: Simon Horman <horms@verge.net.au>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
Wensong Zhang <wensong@linux-vs.org>,
Julian Anastasov <ja@ssi.bg>, Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 1/4] IPVS: Add documentation for new sysctl entries
Date: Tue, 27 Sep 2011 07:07:48 +0900 [thread overview]
Message-ID: <20110926220748.GB5314@verge.net.au> (raw)
In-Reply-To: <4E80B379.2040701@xenotime.net>
On Mon, Sep 26, 2011 at 10:16:41AM -0700, Randy Dunlap wrote:
> On 09/25/2011 06:23 PM, Simon Horman wrote:
> > Add missing documentation for conntrack, snat_reroute and sync_version.
> >
> > Also fix up a typo, IPVS_DEBUG should be IP_VS_DEBUG.
> >
> > Signed-off-by: Simon Horman <horms@verge.net.au>
> >
> > conntrack
> > ---
> > Documentation/networking/ipvs-sysctl.txt | 53 +++++++++++++++++++++++++++++-
> > 1 files changed, 52 insertions(+), 1 deletions(-)
> >
> > diff --git a/Documentation/networking/ipvs-sysctl.txt b/Documentation/networking/ipvs-sysctl.txt
> > index 4ccdbca..5214339 100644
> > --- a/Documentation/networking/ipvs-sysctl.txt
> > +++ b/Documentation/networking/ipvs-sysctl.txt
> > @@ -15,6 +15,23 @@ amemthresh - INTEGER
> > enabled and the variable is automatically set to 2, otherwise
> > the strategy is disabled and the variable is set to 1.
> >
> > +conntrack - BOOLEAN
> > + 0 - disabled (default)
> > + not 0 - enabled
> > +
> > + If set, maintain connection tracking entries for
> > + connections handled by IPVS.
> > +
> > + This should be enabled if connections handled by IPVS are to be
> > + also handled by stateful firewall rules. That is, iptables rules
> > + that make use of connection tracking. It is a performance
> > + optimisation to disable this setting otherwise.
> > +
> > + Connections handled by the IPVS FTP application module
> > + will have connection tracking entries regardless of this setting.
> > +
> > + Only available when IPVS is compiled with the CONFIG_IP_VS_NFCT
>
> seems to be missing something. Maybe
>
> Only available when IPVS is compiled with CONFIG_IP_VS_NFCT enabled.
> or
> Only available when IPVS is compiled with the CONFIG_IP_VS_NFCT
> symbol enabled.
>
> > +
> > cache_bypass - BOOLEAN
> > 0 - disabled (default)
> > not 0 - enabled
> > @@ -39,7 +56,7 @@ debug_level - INTEGER
> > 11 - IPVS packet handling (ip_vs_in/ip_vs_out)
> > 12 or more - packet traversal
> >
> > - Only available when IPVS is compiled with the CONFIG_IPVS_DEBUG
> > + Only available when IPVS is compiled with the CONFIG_IP_VS_DEBUG
>
> with CONFIG_IP_VS_DEBUG enabled.
>
> >
> > Higher debugging levels include the messages for lower debugging
> > levels, so setting debug level 2, includes level 0, 1 and 2
Thanks Randy,
I was just blindly copying the existing language.
I'll make a follow up patch which incorporates your suggestions.
next prev parent reply other threads:[~2011-09-26 22:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 1:23 [PATCH 0/4] IPVS: sysctl Documentation and Various Clean-Ups Simon Horman
2011-09-26 1:23 ` [PATCH 1/4] IPVS: Add documentation for new sysctl entries Simon Horman
2011-09-26 17:16 ` Randy Dunlap
2011-09-26 22:07 ` Simon Horman [this message]
2011-09-26 1:23 ` [PATCH 2/4] IPVS: Remove unused parameter from ip_vs_confirm_conntrack() Simon Horman
2011-09-26 1:23 ` [PATCH 3/4] IPVS: Remove unused return value of protocol state transitions Simon Horman
2011-09-26 1:23 ` [PATCH 4/4] IPVS: Removed unused variables Simon Horman
2011-09-26 5:39 ` [PATCH 0/4] IPVS: sysctl Documentation and Various Clean-Ups Julian Anastasov
2011-09-26 8:37 ` Simon Horman
2011-09-26 6:43 ` Hans Schillstrom
2011-09-26 8:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926220748.GB5314@verge.net.au \
--to=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox