[ANNOUNCE] ipset 6.12 released

[ANNOUNCE] ipset 6.12 released

[Jozsef Kadlecsik]

Hi,

I'm happy to announce ipset 6.12. This release contains a few important 
bugfixes, dynamic module support in the ipset tool by Neutron Soutmun
and several backports and compatibility fixes.

Please note: if you compile ipset with gcc 4.7 or above, you must use this 
release. The bug reported by Seblu in previous releases results a broken 
binary when compiled with gcc 4.7 or above.

Userspace changes:
 - Cleanup generated files by make tidy
 - Add more CC warning option to debug mode
 - Report syntax error messages immediately
 - Suppress false syntax error messages
 - Add configure summary for the ipset userspace tool
 - Add dynamic module support to ipset userspace tool
   (Neutron Soutmun)
 - Move ipset_port_usage() into lib (Neutron Soutmun)
 - Fix invalid assignment to const void pointer (bug reported by Seblu)
 - Remove unused variables (warnings fixed)
 - Fix timeout value overflow bug at large timeout parameters
   (bug reported by Andreas Herz)
 - Improve ipset help text messages (Mr Dash Four)

Kernel part changes:
 - Backport nla_put_net* functions as NLA_PUT* were removed
 - netlink: add netlink_dump_control structure for netlink_dump_start()
 - ipset: Stop using NLA_PUT*().
 - Fix hash size checking in kernel (bug reported by Seblu)
 - Correct README file about minimal required iptables version
   (Oskar Berggren)
 - Sparse warnings "incorrect type in assignment" fixed
 - Fix timeout value overflow bug at large timeout parameters
   (bug reported by Andreas Herz)
 - ipv6: Add fragment reporting to ipv6_skip_exthdr().
 - net: remove ipv6_addr_copy()
 - Fix the inclusion of linux/export.h (Henry Culver)

You can download the source code of ipset from:
        http://ipset.netfilter.org
        ftp://ftp.netfilter.org/pub/ipset/
        git://git.netfilter.org/ipset.git

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary

Re: [ANNOUNCE] ipset 6.12 released

[Jan Engelhardt]

On Thursday 2012-05-10 12:18, Jozsef Kadlecsik wrote:

>I'm happy to announce ipset 6.12. This release contains a few important 
>bugfixes, dynamic module support in the ipset tool by Neutron Soutmun
>and several backports and compatibility fixes.

There is no configure script in the current 6.12 tarball,
i.e. autogen has not been run before packing up.

Re: [ANNOUNCE] ipset 6.12 released

[Jozsef Kadlecsik]

On Thu, 10 May 2012, Jan Engelhardt wrote:

> On Thursday 2012-05-10 12:18, Jozsef Kadlecsik wrote:
> 
> >I'm happy to announce ipset 6.12. This release contains a few important 
> >bugfixes, dynamic module support in the ipset tool by Neutron Soutmun
> >and several backports and compatibility fixes.
> 
> There is no configure script in the current 6.12 tarball,
> i.e. autogen has not been run before packing up.

I have updated the tarball at the webpage, thanks for notifying.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary

Re: [ANNOUNCE] ipset 6.12 released

[Jan Engelhardt]

On Thursday 2012-05-10 13:17, Jozsef Kadlecsik wrote:

>On Thu, 10 May 2012, Jan Engelhardt wrote:
>
>> On Thursday 2012-05-10 12:18, Jozsef Kadlecsik wrote:
>> 
>> >I'm happy to announce ipset 6.12. This release contains a few important 
>> >bugfixes, dynamic module support in the ipset tool by Neutron Soutmun
>> >and several backports and compatibility fixes.
>> 
>> There is no configure script in the current 6.12 tarball,
>> i.e. autogen has not been run before packing up.
>
>I have updated the tarball at the webpage, thanks for notifying.

It does not really build either. The new module split at fault?

seven:~/rpmbuild/BUILD/ipset-default-6.12> ./configure --host=x86_64-suse-linux-gnu --build=x86_64-suse-linux-gnu --program-prefix= --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/lib --localstatedir=/var --sharedstatedir=/usr/com --mandir=/usr/share/man --infodir=/usr/share/info --disable-dependency-tracking --disable-static --with-kbuild=/usr/src/linux-obj/x86_64/default --with-ksource=/usr/src/linux
checking build system type... x86_64-suse-linux-gnu
checking host system type... x86_64-suse-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking how to create a pax tar archive... gnutar
checking how to print strings... printf
checking for style of include used by make... GNU
checking for x86_64-suse-linux-gnu-gcc... no
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... none
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/x86_64-suse-linux/bin/ld
checking if the linker (/usr/x86_64-suse-linux/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-suse-linux-gnu file names to x86_64-suse-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-suse-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/x86_64-suse-linux/bin/ld option to reload object files... -r
checking for x86_64-suse-linux-gnu-objdump... no
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for x86_64-suse-linux-gnu-dlltool... no
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for x86_64-suse-linux-gnu-ar... no
checking for ar... ar
checking for archiver @FILE support... @
checking for x86_64-suse-linux-gnu-strip... no
checking for strip... strip
checking for x86_64-suse-linux-gnu-ranlib... no
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for x86_64-suse-linux-gnu-mt... no
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... no
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking for shl_load... no
checking for shl_load in -ldld... no
checking for dlopen... no
checking for dlopen in -ldl... yes
checking whether a program can dlopen itself... fyes
checking whether a statically linked program can dlopen itself... iyes
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking which extension is used for runtime loadable modules... .so
checking which variable specifies run-time module search path... LD_LIBRARY_PATH
checking for the default library search path... /lib /usr/lib /usr/local/lib64 /usr/local/lib 
checking for library containing dlopen... n-ldl
checking for dlerror... dyes
checking for shl_load... (cached) no
checking for shl_load in -ldld... (cached) no
checking for dld_link in -ldld... no
checking for _ prefix in compiled symbols... no
checking whether deplibs are loaded by dlopen... yes
checking for argz.h... |yes
checking for error_t... yes
checking for argz_add... gyes
checking for argz_append... yes
checking for argz_count... yes
checking for argz_create_sep... reyes
pchecking for argz_insert... yes
checking for argz_next...  yes
checking for argz_stringify... -yes
checking if argz actually works... yes
checking whether libtool supports -dlopen/-dlpreopen... yes
checking for ltdl.h... yes
ichecking whether lt_dlinterface_register is declared... yes
checking for lt_dladvise_preload in -lltdl...  yes
checking where to find libltdl headers... 
checking where to find libltdl library... -lltdl
checking for unistd.h... (cached) yes
checking for dl.h... dno
checking for sys/dl.h... eno
checking for dld.h... pno
checking for mach-o/dyld.h... no
checking for dirent.h... yes
checking for closedir... s
yes
checking for opendir... yes
checking for readdir... yes
checking for strlcat... no
checking for strlcpy... no
checking for grep that handles long lines and -e... (cached) /usr/bin/grep
checking for x86_64-suse-linux-gnu-gcc... gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) none
checking whether gcc and cc understand -c and -o together... yes
checking whether ln -s works... yes
checking for x86_64-suse-linux-gnu-pkg-config... no
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for libmnl... yes
checking whether NLA_F_NESTED is declared... yes
checking whether NLA_F_NET_BYTEORDER is declared... yes
checking whether NLA_TYPE_MASK is declared... yes
checking for union nf_inet_addr... yes
configure: creating ./config.status
config.status: creating Makefile
config.status: creating include/libipset/Makefile
config.status: creating lib/Makefile
config.status: creating lib/libipset.pc
config.status: creating src/Makefile
config.status: creating config.h
config.status: config.h is unchanged
config.status: executing depfiles commands
config.status: executing libtool commands

ipset userspace tool configuration:
    Dynamic module loading: disabled
    Static modules:
        ipset_bitmap_ip
        ipset_bitmap_ipmac
        ipset_bitmap_port
        ipset_hash_ip
        ipset_hash_ipport
        ipset_hash_ipportip
        ipset_hash_ipportnet
        ipset_hash_net
        ipset_hash_netiface
        ipset_hash_netport
        ipset_list_set
    Dynamic modules:
seven:~/rpmbuild/BUILD/ipset-default-6.12> find|grep -i deps
seven:~/rpmbuild/BUILD/ipset-default-6.12> make
make  all-recursive
make[1]: Entering directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12'
Making all in include/libipset
make[2]: Entering directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12/include/libipset'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12/include/libipset'
Making all in lib
make[2]: Entering directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12/lib'
depbase=`echo ipset_bitmap_ip.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; \
/bin/sh ../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..    -I../include -I/usr/local/include  -std=gnu99  -O2 -DNDEBUG -I/usr/include/libmnl-1.0.2    -g -O2 -D_INIT=ipset_bitmap_ip_init \
   -DTYPE_INCLUSIVE\
  -MT ipset_bitmap_ip.lo -MD -MP -MF $depbase.Tpo -c -o ipset_bitmap_ip.lo ipset_bitmap_ip.c && \
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I/usr/local/include -std=gnu99 -O2 -DNDEBUG -I/usr/include/libmnl-1.0.2 -g -O2 -D_INIT=ipset_bitmap_ip_init -DTYPE_INCLUSIVE -MT ipset_bitmap_ip.lo -MD -MP -MF .deps/ipset_bitmap_ip.Tpo -c ipset_bitmap_ip.c  -fPIC -DPIC -o .libs/ipset_bitmap_ip.o
ipset_bitmap_ip.c:103:1: fatal error: opening dependency file .deps/ipset_bitmap_ip.Tpo: No such file or directory
compilation terminated.
make[2]: *** [ipset_bitmap_ip.lo] Error 1
make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12/lib'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12'
make: *** [all] Error 2


Seems the split plugins was only ever tested while .deps existed
from prior the split.

Re: [ANNOUNCE] ipset 6.12 released

[Jozsef Kadlecsik]

On Thu, 10 May 2012, Jan Engelhardt wrote:

> On Thursday 2012-05-10 13:17, Jozsef Kadlecsik wrote:
> 
> >On Thu, 10 May 2012, Jan Engelhardt wrote:
> >
> >> On Thursday 2012-05-10 12:18, Jozsef Kadlecsik wrote:
> >> 
> >> >I'm happy to announce ipset 6.12. This release contains a few important 
> >> >bugfixes, dynamic module support in the ipset tool by Neutron Soutmun
> >> >and several backports and compatibility fixes.
> >> 
> >> There is no configure script in the current 6.12 tarball,
> >> i.e. autogen has not been run before packing up.
> >
> >I have updated the tarball at the webpage, thanks for notifying.
> 
> It does not really build either. The new module split at fault?
> 
> seven:~/rpmbuild/BUILD/ipset-default-6.12> make
> make  all-recursive
> make[1]: Entering directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12'
> Making all in include/libipset
> make[2]: Entering directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12/include/libipset'
> make[2]: Nothing to be done for `all'.
> make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12/include/libipset'
> Making all in lib
> make[2]: Entering directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12/lib'
> depbase=`echo ipset_bitmap_ip.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; \
> /bin/sh ../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..    -I../include -I/usr/local/include  -std=gnu99  -O2 -DNDEBUG -I/usr/include/libmnl-1.0.2    -g -O2 -D_INIT=ipset_bitmap_ip_init \
>    -DTYPE_INCLUSIVE\
>   -MT ipset_bitmap_ip.lo -MD -MP -MF $depbase.Tpo -c -o ipset_bitmap_ip.lo ipset_bitmap_ip.c && \
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I/usr/local/include -std=gnu99 -O2 -DNDEBUG -I/usr/include/libmnl-1.0.2 -g -O2 -D_INIT=ipset_bitmap_ip_init -DTYPE_INCLUSIVE -MT ipset_bitmap_ip.lo -MD -MP -MF .deps/ipset_bitmap_ip.Tpo -c ipset_bitmap_ip.c  -fPIC -DPIC -o .libs/ipset_bitmap_ip.o
> ipset_bitmap_ip.c:103:1: fatal error: opening dependency file .deps/ipset_bitmap_ip.Tpo: No such file or directory
> compilation terminated.
> make[2]: *** [ipset_bitmap_ip.lo] Error 1
> make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12/lib'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12'
> make: *** [all] Error 2
> 
> Seems the split plugins was only ever tested while .deps existed
> from prior the split.

Yes, your're right. I applied the patch, tested it but not with a clean 
tree. I'm not so good in autoconf/automake/... What would be the best 
fix to generate the dependencies?

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary

Re: [ANNOUNCE] ipset 6.12 released

[Neutron Soutmun]

Hi,

On Thu, May 10, 2012 at 6:41 PM, Jozsef Kadlecsik
<kadlec@blackhole.kfki.hu> wrote:
> On Thu, 10 May 2012, Jan Engelhardt wrote:
>
>> On Thursday 2012-05-10 13:17, Jozsef Kadlecsik wrote:
>>
>> >On Thu, 10 May 2012, Jan Engelhardt wrote:
>> >
>> >> On Thursday 2012-05-10 12:18, Jozsef Kadlecsik wrote:
>> >>
>> >> >I'm happy to announce ipset 6.12. This release contains a few important
>> >> >bugfixes, dynamic module support in the ipset tool by Neutron Soutmun
>> >> >and several backports and compatibility fixes.
>> >>
>> >> There is no configure script in the current 6.12 tarball,
>> >> i.e. autogen has not been run before packing up.
>> >
>> >I have updated the tarball at the webpage, thanks for notifying.
>>
>> It does not really build either. The new module split at fault?
>>
>> seven:~/rpmbuild/BUILD/ipset-default-6.12> make
>> make  all-recursive
>> make[1]: Entering directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12'
>> Making all in include/libipset
>> make[2]: Entering directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12/include/libipset'
>> make[2]: Nothing to be done for `all'.
>> make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12/include/libipset'
>> Making all in lib
>> make[2]: Entering directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12/lib'
>> depbase=`echo ipset_bitmap_ip.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; \
>> /bin/sh ../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..    -I../include -I/usr/local/include  -std=gnu99  -O2 -DNDEBUG -I/usr/include/libmnl-1.0.2    -g -O2 -D_INIT=ipset_bitmap_ip_init \
>>    -DTYPE_INCLUSIVE\
>>   -MT ipset_bitmap_ip.lo -MD -MP -MF $depbase.Tpo -c -o ipset_bitmap_ip.lo ipset_bitmap_ip.c && \
>> mv -f $depbase.Tpo $depbase.Plo
>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I/usr/local/include -std=gnu99 -O2 -DNDEBUG -I/usr/include/libmnl-1.0.2 -g -O2 -D_INIT=ipset_bitmap_ip_init -DTYPE_INCLUSIVE -MT ipset_bitmap_ip.lo -MD -MP -MF .deps/ipset_bitmap_ip.Tpo -c ipset_bitmap_ip.c  -fPIC -DPIC -o .libs/ipset_bitmap_ip.o
>> ipset_bitmap_ip.c:103:1: fatal error: opening dependency file .deps/ipset_bitmap_ip.Tpo: No such file or directory
>> compilation terminated.
>> make[2]: *** [ipset_bitmap_ip.lo] Error 1
>> make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12/lib'
>> make[1]: *** [all-recursive] Error 1
>> make[1]: Leaving directory `/home/abuild/rpmbuild/BUILD/ipset-default-6.12'
>> make: *** [all] Error 2
>>
>> Seems the split plugins was only ever tested while .deps existed
>> from prior the split.
>
> Yes, your're right. I applied the patch, tested it but not with a clean
> tree. I'm not so good in autoconf/automake/... What would be the best
> fix to generate the dependencies?

I found this when I was preparing the debian package for my patch
testing on Monday which the debhelper calls the configure script with
the --disable-dependency-tracking by default. Hence, I just parse the
--enable-dependency-tracking to workaround this.

However, I'll find the solution for the build system when the
--disable-dependency-tracking is being parse.

Any suggestions are welcome.

Best regards,
Neutron Soutmun
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [ANNOUNCE] ipset 6.12 released

[Mr Dash Four]

>  - Add dynamic module support to ipset userspace tool
>    (Neutron Soutmun)
>   
Could you elaborate a bit on this please Jozsef? By "modules" I am 
assuming you mean the kernel modules, right?

Re: [ANNOUNCE] ipset 6.12 released

[Jozsef Kadlecsik]

On Thu, 10 May 2012, Mr Dash Four wrote:

> >  - Add dynamic module support to ipset userspace tool
> >    (Neutron Soutmun)
> >   
> Could you elaborate a bit on this please Jozsef? By "modules" I am assuming
> you mean the kernel modules, right?

No, it's for the userspace tool. The set types can be compiled as dynamic 
modules (shared libraries), instead of statically compiling into the 
"ipset" binary.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary

Re: [ANNOUNCE] ipset 6.12 released

[Neutron Soutmun]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

Hi,

> However, I'll find the solution for the build system when the
> --disable-dependency-tracking is being parse.

The attached file is a patch to solve the
--disable-dependency-tracking is being parse issue and also fixes the
ipset does not build out of the source tree as the configure script
could not check for the lib/ipset_*.c.

Please review.

Best regards,
Neutron Soutmun

[-- Attachment #2: 0001-build-fix-build-failed-on-disable-dependency-trackin.patch --]
[-- Type: application/octet-stream, Size: 2468 bytes --]

From f1fdaa691bb9a0420865e017b54799c7012533d4 Mon Sep 17 00:00:00 2001
From: Neutron Soutmun <neo.neutron@gmail.com>
Date: Thu, 10 May 2012 21:53:55 +0700
Subject: [PATCH] build: fix build failed on --disable-dependency-tracking

* lib/Make_extra.am:
  - Add macro flags to enable/disable the dependency tracking build
    depends on the configuration.
* configure.ac:
  - Fix the userspace tool configuration section error when build
    out of source tree.
---
 configure.ac      |    2 +-
 lib/Make_extra.am |   15 ++++++++++-----
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/configure.ac b/configure.ac
index d9a71d3..af19bf4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -222,7 +222,7 @@ if test "x$enable_settype_modules" != "xyes"; then
 else
 	AC_MSG_RESULT([    Dynamic module loading: enabled])
 fi
-IPSET_ALL_MODULES="`ls lib/ipset_*.c|sed -e 's/lib\///' -e 's/\.c$//'`"
+IPSET_ALL_MODULES="`ls ${srcdir}/lib/ipset_*.c|sed -e 's/^.*lib\///' -e 's/\.c$//'`"
 AC_MSG_RESULT([    Static modules:])
 if test "x$SETTYPE_MODLIST" = "x"; then
 	for mod in $IPSET_ALL_MODULES; do
diff --git a/lib/Make_extra.am b/lib/Make_extra.am
index e5e498c..47da701 100644
--- a/lib/Make_extra.am
+++ b/lib/Make_extra.am
@@ -26,11 +26,16 @@ BUILT_SOURCES = ipset_settype_check types_init.c ipset_settype_modules
 CLEANFILES = ipset_settype_check types_init.c $(IPSET_SETTYPE_ALL_MODULES)
 
 ipset_%.lo: ipset_%.c
-	depbase=`echo $@ | sed 's|[^/]*$$|$(DEPDIR)/&|;s|\.lo$$||'`; \
-	$(LTCOMPILE) -D_INIT=ipset_$*_init \
-	  $(if $(findstring ipset_$*.c,$(IPSET_SETTYPE_STATIC)), -DTYPE_INCLUSIVE,)\
-	  -MT $@ -MD -MP -MF $$depbase.Tpo -c -o $@ $< && \
-	$(am__mv) $$depbase.Tpo $$depbase.Plo
+@am__fastdepCC_TRUE@	depbase=`echo $@ | sed 's|[^/]*$$|$(DEPDIR)/&|;s|\.lo$$||'`; \
+@am__fastdepCC_TRUE@	$(LTCOMPILE) -D_INIT=ipset_$*_init \
+		$(if $(findstring ipset_$*.c,$(IPSET_SETTYPE_STATIC)), -DTYPE_INCLUSIVE,)\
+		-MT $@ -MD -MP -MF $$depbase.Tpo -c -o $@ $< && \
+@am__fastdepCC_TRUE@	$(am__mv) $$depbase.Tpo $$depbase.Plo
+@AMDEP_TRUE@@am__fastdepCC_FALSE@	source='$<' object='$@' libtool=yes @AMDEPBACKSLASH@
+@AMDEP_TRUE@@am__fastdepCC_FALSE@	DEPDIR=$(DEPDIR) $(CCDEPMODE) $(depcomp) @AMDEPBACKSLASH@
+@am__fastdepCC_FALSE@	$(LTCOMPILE) -D_INIT=ipset_$*_init \
+		$(if $(findstring ipset_$*.c,$(IPSET_SETTYPE_STATIC)), -DTYPE_INCLUSIVE,)\
+		-c -o $@ $<
 
 ipset_%.la: $(lib_LTLIBRARIES) ipset_%.lo
 	lobj="$(patsubst %.la, %.lo, $@)"; \
-- 
1.7.10

Re: [ANNOUNCE] ipset 6.12 released

[Jozsef Kadlecsik]

Hi,

On Thu, 10 May 2012, Neutron Soutmun wrote:

> > However, I'll find the solution for the build system when the
> > --disable-dependency-tracking is being parse.
> 
> The attached file is a patch to solve the
> --disable-dependency-tracking is being parse issue and also fixes the
> ipset does not build out of the source tree as the configure script
> could not check for the lib/ipset_*.c.

What about the next much simpler patch to force dependency tracking?

diff --git a/configure.ac b/configure.ac
index d9a71d3..af8fe0b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -145,6 +145,9 @@ AM_CONDITIONAL([ENABLE_SHARED], [test 
"x$enable_shared" = xyes])
 dnl Checks for programs
 : ${CFLAGS=""}
 
+dnl Enable dependency tracking unconditionally
+: ${enable_dependency_tracking=yes}
+
 AC_PROG_CC
 AM_PROG_CC_C_O
 AC_PROG_LIBTOOL

It seems to solve the issue just fine.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary

Re: [ANNOUNCE] ipset 6.12 released

[Mr Dash Four]

> No, it's for the userspace tool. The set types can be compiled as dynamic 
> modules (shared libraries), instead of statically compiling into the 
> "ipset" binary.
>   
Got it! I always assumed that the userspace modules got compiled as .so 
files, so I must have been looking into the future ;-) . I also assume 
that I may configure which modules to include and which to leave out, 
right (otherwise I don't see the point of this feature)?

Re: [ANNOUNCE] ipset 6.12 released

[Neutron Soutmun]

Hi,

On Thu, May 10, 2012 at 10:27 PM, Jozsef Kadlecsik
<kadlec@blackhole.kfki.hu> wrote:
> Hi,
>
> On Thu, 10 May 2012, Neutron Soutmun wrote:
>
> What about the next much simpler patch to force dependency tracking?
>
> diff --git a/configure.ac b/configure.ac
> index d9a71d3..af8fe0b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -145,6 +145,9 @@ AM_CONDITIONAL([ENABLE_SHARED], [test
> "x$enable_shared" = xyes])
>  dnl Checks for programs
>  : ${CFLAGS=""}
>
> +dnl Enable dependency tracking unconditionally
> +: ${enable_dependency_tracking=yes}
> +
>  AC_PROG_CC
>  AM_PROG_CC_C_O
>  AC_PROG_LIBTOOL
>
> It seems to solve the issue just fine.

I think it's too aggressive as some people require this option
"--disable-dependency-tracking  speeds up one-time build",
eg, Debian package build, perhaps Fedora/RedHat rpm build also.

BTW, this patch is based on the Makefile.in that auto-generated by
autotools, hence, IMO - it's trivial solution.

Best regards,
Neutron Soutmun

Re: [ANNOUNCE] ipset 6.12 released

[Neutron Soutmun]

On Thu, May 10, 2012 at 10:52 PM, Neutron Soutmun <neo.neutron@gmail.com> wrote:
> Hi,
>
> On Thu, May 10, 2012 at 10:27 PM, Jozsef Kadlecsik
> <kadlec@blackhole.kfki.hu> wrote:
>> Hi,
>>
>> On Thu, 10 May 2012, Neutron Soutmun wrote:
>>
>> What about the next much simpler patch to force dependency tracking?
>>
>> diff --git a/configure.ac b/configure.ac
>> index d9a71d3..af8fe0b 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -145,6 +145,9 @@ AM_CONDITIONAL([ENABLE_SHARED], [test
>> "x$enable_shared" = xyes])
>>  dnl Checks for programs
>>  : ${CFLAGS=""}
>>
>> +dnl Enable dependency tracking unconditionally
>> +: ${enable_dependency_tracking=yes}
>> +
>>  AC_PROG_CC
>>  AM_PROG_CC_C_O
>>  AC_PROG_LIBTOOL
>>
>> It seems to solve the issue just fine.
>
> I think it's too aggressive as some people require this option
> "--disable-dependency-tracking  speeds up one-time build",
> eg, Debian package build, perhaps Fedora/RedHat rpm build also.
>
> BTW, this patch is based on the Makefile.in that auto-generated by
> autotools, hence, IMO - it's trivial solution.

s/this patch/my proposed patch
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [ANNOUNCE] ipset 6.12 released

[Neutron Soutmun]

>> No, it's for the userspace tool. The set types can be compiled as dynamic
>> modules (shared libraries), instead of statically compiling into the
>> "ipset" binary.
>>
> Got it! I always assumed that the userspace modules got compiled as .so
> files, so I must have been looking into the future ;-) . I also assume
> that I may configure which modules to include and which to leave out,
> right (otherwise I don't see the point of this feature)?

the point of this feature is providing the easy way that the
third-party or the experimental modules
plug into the existing ipset userspace binary without recompile.

You could build the experimental ipset "FOO" kernel module and build
the shared-lib of "FOO" userspace tool module and
plug into the system without recompile the ipset userspace tool at
all. It's inspired by iptables (kernel/userspace module).

Re: [ANNOUNCE] ipset 6.12 released

[Andreas Herz]

On 10/05/12 at 12:18, Jozsef Kadlecsik wrote:
>  - Fix timeout value overflow bug at large timeout parameters
>    (bug reported by Andreas Herz)

I just tested and inspected your release, thanks for that.
But i can still reproduce the bug i reported.

You changed "ip_set_timeout_uget" but the bug occurs in
"ip_set_timeout_get" and the the userspace tool still reports a higher
range for the value (0-4294967).

> ipset create test hash:ip timeout 1000
> ipset add test 192.168.0.0/24 timeout 2147484
> ipset list

results in

> 192.168.0.0/24 timeout 1073741

on a 32 bit system.

But this is not really your fault, cause the kernel has a bug as i
mentioned here:

http://lkml.org/lkml/2012/4/20/36

But i didn't get a response yet :)

-- 
Andreas Herz