From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org
Subject: Re: [PATCH] iptables-restore: move code to add_param_to_argv, cleanup (fix gcc-4.7)
Date: Fri, 3 Aug 2012 11:15:35 +0200 [thread overview]
Message-ID: <20120803091535.GA11165@1984> (raw)
In-Reply-To: <alpine.LNX.2.01.1208022136350.21772@frira.zrqbmnf.qr>
On Thu, Aug 02, 2012 at 09:37:10PM +0200, Jan Engelhardt wrote:
>
> On Monday 2012-07-30 03:37, Pablo Neira Ayuso wrote:
> >> > // here param_buffer[1024] is lost, so any var pointing
> >> > // to it can mess stack
> >> >
> >> > previous gcc were probably not so aggressive.
> >>
> >> Oh well, add_argv() does a strdup(), so iptables code seems fine.
> >
> >I thought the same, but one contributor has put some on light on this.
> >
> >I'm going to revert the patch that I applied to fix this and apply
> >the one that comes with this email instead.
> >
> >It contains a simple description of the problem, I think it's good for
> >the record (distro maintainers will likely google for this).
>
> Your code cleanup, by moving the code into a separate function,
> is however still desired :)
OK, it's back:
http://git.netfilter.org/cgi-bin/gitweb.cgi?p=iptables.git;a=commit;h=23a98b56935c42ef460020e37a9ff8006eee58e2
next prev parent reply other threads:[~2012-08-03 9:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 10:38 [PATCH] iptables-restore: move code to add_param_to_argv, cleanup (fix gcc-4.7) pablo
2012-07-23 11:29 ` Eric Dumazet
2012-07-23 11:38 ` Eric Dumazet
2012-07-23 13:08 ` Pablo Neira Ayuso
2012-07-30 1:37 ` Pablo Neira Ayuso
2012-07-30 1:40 ` Pablo Neira Ayuso
2012-08-02 19:37 ` Jan Engelhardt
2012-08-03 9:15 ` Pablo Neira Ayuso [this message]
2012-07-23 12:19 ` Jan Engelhardt
2012-07-23 13:04 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803091535.GA11165@1984 \
--to=pablo@netfilter.org \
--cc=eric.dumazet@gmail.com \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).