Linux Netfilter discussions
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Kiernan George <kbg98@vt.edu>, netfilter@vger.kernel.org
Subject: Re: ABI Breakage - nftnl_rule_parse_attr_cb
Date: Wed, 22 Jun 2022 17:55:59 +0200	[thread overview]
Message-ID: <20220622155559.GA18555@breakpoint.cc> (raw)
In-Reply-To: <YrM17Qkvoo+JNrT1@salvia>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Wed, Jun 22, 2022 at 09:24:25AM -0400, Kiernan George wrote:
> > This is the relevant line where I build my header:
> > nlh = nftnl_rule_nlmsg_build_hdr(mnl_nlmsg_batch_current(batch),
> > NFT_MSG_NEWRULE, family, NLM_F_APPEND | NLM_F_EXCL | NLM_F_CREATE |
> > NLM_F_ECHO | NLM_F_ACK, seq++);
> > 
> > If I remove NLM_F_ECHO, it fixes my issue, but I would prefer to keep
> > this unless there is a better way to get the created rule's handle. I
> > also set the handle directly:
> > mnl_attr_put_u64(nlh, NFTNL_RULE_POSITION, htobe64(handle));
> 
> Makes no sense. Flags are irrelevant for the ABI breakage you are
> reporting. Send us a reproducer.

Probably corrupted or too-small receive buffer w. garbage fed into
netlink parser.

Impossible to say without reproducer.

      reply	other threads:[~2022-06-22 15:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21 20:07 ABI Breakage - nftnl_rule_parse_attr_cb Kiernan George
2022-06-22  7:36 ` Pablo Neira Ayuso
2022-06-22 13:24   ` Kiernan George
2022-06-22 15:31     ` Pablo Neira Ayuso
2022-06-22 15:55       ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220622155559.GA18555@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=kbg98@vt.edu \
    --cc=netfilter@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox