netfilter.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Sowden <jeremy@azazel.net>
To: Netfilter <netfilter@vger.kernel.org>
Cc: Slavko <linux@slavino.sk>
Subject: Re: Log ARP headers
Date: Mon, 3 Mar 2025 22:00:55 +0000	[thread overview]
Message-ID: <20250303220055.GA4034310@celephais.dreamlands> (raw)
In-Reply-To: <88D0D02C-9C84-428F-B62B-EBA5E359D325@slavino.sk>

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

On 2025-03-03, at 21:52:07 +0000, Slavko wrote:
> On 3. marca 2025 19:35:33 UTC, Florian Westphal <fw@strlen.de> wrote:
> > This is only required for logging that is triggered internally,
> > e.g. for nf_conntrack.log_Invalid.
>
> Oh, many thanks, that was not clear for me from any related article.
>
> > I think this is missing support in ulogd2.
> >
> > Untested, to give you some starting point:
> > (3 is NFPROTO_ARP).
> >
> > --- a/filter/raw2packet/ulogd_raw2packet_BASE.c
> > +++ b/filter/raw2packet/ulogd_raw2packet_BASE.c
> > @@ -959,6 +959,8 @@ static int _interp_pkt(struct ulogd_pluginstance *pi)
> >                 return _interp_ipv6hdr(pi, len);
> >         case AF_BRIDGE:
> >                 return _interp_bridge(pi, len);
> > +       case 3:
> > +               return _interp_arp(pi, len);
> >         }
> >         return ULOGD_IRET_OK;
> >  }
>
> Unfortunately, i don't speak C ;-)

I do.

> I understand this change, but i cannot see all consequence,
>
> Any chance that it will go to ulogd itself? Or i have to maintain
> this patch locally only? (I mean for future versions)

I'll look at this when I get a moment.

J.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 931 bytes --]

  reply	other threads:[~2025-03-03 22:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27 16:51 Log ARP headers Slavko
2025-03-03 19:35 ` Florian Westphal
2025-03-03 21:52   ` Slavko
2025-03-03 22:00     ` Jeremy Sowden [this message]
2025-04-05  9:54       ` Slavko
2025-04-18 11:00         ` Jeremy Sowden
2025-04-18 11:33           ` Slavko
2025-05-25  7:51       ` Slavko
2025-05-25 10:33         ` Florian Westphal
2025-05-25 17:24           ` Jeremy Sowden
2025-03-03 22:03     ` Florian Westphal
2025-03-03 22:20       ` Slavko
2025-03-05 13:20       ` Slavko
2025-03-05 13:30         ` Slavko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250303220055.GA4034310@celephais.dreamlands \
    --to=jeremy@azazel.net \
    --cc=linux@slavino.sk \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).