netfilter.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: pgnd <pgnd@dev-mail.net>
To: netfilter@vger.kernel.org
Subject: syntax issues when reducing rules through grouping ?
Date: Thu, 18 Jul 2024 15:44:45 -0400	[thread overview]
Message-ID: <374dc2fb-f3e1-4599-a46f-524fd894ee32@dev-mail.net> (raw)

i've migrated some fw code to nftables, and am cleaning up my sources -- at this point, for my own readability.

i've managed to so far miss any clear writeups on such housekeeping, so using some trial-n-error :-/


when involving marks in nat/mangle chains, what's valid, or not, is a bit fuzzy.

in this sample script

	cat tmp.nft
		#!/usr/sbin/nft -f

		define VPN = "A"
		define LAN = "B"
		define SVR1 = "1.1.1.1"
		define SVR2 = "2.2.2.2"

		table nat {
			chain prerouting {
				type nat hook prerouting priority -150; policy accept;

				# SET1
				meta mark set 0x02 meta iifname "$VPN" meta oifname "$LAN" ip daddr $SVR1 udp dport 53
				meta mark set 0x02 meta iifname "$VPN" meta oifname "$LAN" ip daddr $SVR1 tcp dport 53
				meta mark set 0x02 meta iifname "$VPN" meta oifname "$LAN" ip daddr $SVR2 udp dport 25
				meta mark set 0x02 meta iifname "$VPN" meta oifname "$LAN" ip daddr $SVR2 tcp dport 465

				# SET2 (This seem a bit tortured, but it's fewer lines ...)
				meta mark set 0x02 meta iifname "$VPN" meta oifname "$LAN" ip daddr $SVR1 meta l4proto {tcp, udp} th dport 53
				meta mark set 0x02 meta iifname "$VPN" meta oifname "$LAN" ip daddr $SVR2 tcp dport { 25, 465 }

				# SET3
				meta mark set 0x02 {
24					meta iifname "$VPN" meta oifname "$LAN" ip daddr $SVR1 meta l4proto {tcp, udp} th dport 53
25					meta iifname "$VPN" meta oifname "$LAN" ip daddr $SVR2 tcp dport { 25, 465 }
26				}
27
28			}
29		}


rule group "SETs" 1, 2 & 3 are _intended_ to be functionally equivalent, but simply increasingly "grouped" for convenience/readability (yes, arguable!)


testing, SET1 & SET2 seem OK, but SET3 is clearly unhappy,

	nft -c -f tmp.nft
		tmp.nft:24:4-7: Error: syntax error, unexpected meta
		                        meta iifname "$VPN" meta oifname "$LAN" ip daddr $SVR1 meta l4proto {tcp, udp} th dport 53
		                        ^^^^
		tmp.nft:29:1-1: Error: syntax error, unexpected '}'
		}
		^


what's specifically DISallowed in my SET3 syntax usage?

what'd be the 'most grouped' that SET can validly be?


             reply	other threads:[~2024-07-18 19:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18 19:44 pgnd [this message]
2024-07-18 21:00 ` syntax issues when reducing rules through grouping ? Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=374dc2fb-f3e1-4599-a46f-524fd894ee32@dev-mail.net \
    --to=pgnd@dev-mail.net \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).