From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: netfilter@vger.kernel.org
Subject: Re: [PATCH 01/29] : xt_sctp: simplify xt_sctp.h
Date: Wed, 26 Mar 2008 21:15:20 +0100 [thread overview]
Message-ID: <47EAAED8.5040903@trash.net> (raw)
In-Reply-To: <720350a38b1dbd43c907d5d81decd6edd6725d81.1206469820.git.jengelh@computergmbh.de>
Jan Engelhardt wrote:
> diff --git a/include/linux/netfilter/xt_sctp.h b/include/linux/netfilter/xt_sctp.h
> index dd5a4fd..32000ba 100644
> --- a/include/linux/netfilter/xt_sctp.h
> +++ b/include/linux/netfilter/xt_sctp.h
> @@ -37,68 +37,54 @@ struct xt_sctp_info {
>
> #define SCTP_CHUNKMAP_SET(chunkmap, type) \
> do { \
> - chunkmap[type / bytes(u_int32_t)] |= \
> + (chunkmap)[type / bytes(u_int32_t)] |= \
This "bytes()" stuff also deserves to die.
Anyways, applied.
prev parent reply other threads:[~2008-03-26 20:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LNX.1.10.0803251914060.2240@fbirervta.pbzchgretzou.qr>
2008-03-25 18:29 ` [PATCH 01/29] : xt_sctp: simplify xt_sctp.h Jan Engelhardt
2008-03-25 18:29 ` [PATCH 02/29] : annotate xtables targets with const and remove casts Jan Engelhardt
2008-03-26 20:17 ` Patrick McHardy
2008-03-25 18:29 ` [PATCH 03/29] : annotate {arp,ip,ip6,x}tables with const Jan Engelhardt
2008-03-25 18:29 ` [PATCH 04/29] : annotate rest of nf_conntrack_* " Jan Engelhardt
2008-03-26 20:24 ` Patrick McHardy
2008-03-25 18:29 ` [PATCH 05/29] : annotate rest of nf_nat_* " Jan Engelhardt
2008-03-25 18:29 ` [PATCH 06/29] : Use unsigned types for hooknum and pf vars Jan Engelhardt
2008-03-25 18:29 ` [PATCH 07/29] : remove arpt_table indirection macro Jan Engelhardt
2008-03-25 18:30 ` [PATCH 08/29] : remove arpt_target " Jan Engelhardt
2008-03-25 18:30 ` [PATCH 09/29] : remove ARPT_{STANDARD,ERROR}_TARGET " Jan Engelhardt
2008-03-25 18:30 ` [PATCH 10/29] : remove unused ARPT_ALIGN indirection macros Jan Engelhardt
2008-03-25 18:30 ` [PATCH 11/29] : remove arpt_(un)register_target " Jan Engelhardt
2008-03-25 18:30 ` [PATCH 12/29] : remove ARPT_{CONTINUE,RETURN} " Jan Engelhardt
2008-03-25 18:30 ` [PATCH 13/29] " Jan Engelhardt
2008-03-25 18:30 ` [PATCH 14/29] : rename NF_ARP to AF_ARP and assign a non-clashing value Jan Engelhardt
2008-03-25 18:30 ` [PATCH 15/29] : Implement AF_UNSPEC as a wildcard for extensions Jan Engelhardt
2008-03-25 18:30 ` [PATCH 16/29] : Explicitly initialize .priority in arptable_filter Jan Engelhardt
2008-03-25 18:30 ` [PATCH 17/29] : Rename ipt_recent to xt_recent Jan Engelhardt
2008-03-25 18:30 ` [PATCH 18/29] : xt_recent: IPv6 support Jan Engelhardt
2008-03-25 18:30 ` [PATCH 19/29] : nf_nat: autoload IPv4 connection tracking Jan Engelhardt
2008-03-25 18:30 ` [PATCH 20/29] : Use bool in nf_conntrack_l4proto Jan Engelhardt
2008-03-25 18:30 ` [PATCH 21/29] : Use bool in nf_conntrack_l3proto Jan Engelhardt
2008-03-25 18:30 ` [PATCH 22/29] : nf_conntrack_sctp: const annotations Jan Engelhardt
2008-03-25 18:30 ` [PATCH 23/29] : Use bool in nf_conntrack_tuple.h Jan Engelhardt
2008-03-25 18:30 ` [PATCH 24/29] : Replace anon union by nf_conntrack_man_proto Jan Engelhardt
2008-03-25 18:30 ` [PATCH 25/29] : Give AF-independent extensions an arpt_ alias Jan Engelhardt
2008-03-25 18:30 ` [PATCH 26/29] : Make Ebtables use Xtables infrastructure Jan Engelhardt
2008-03-25 18:30 ` [PATCH 27/29] : Deploy a prefix_length-to-network mask mapping table Jan Engelhardt
2008-03-25 18:30 ` [PATCH 28/29] : xt_length match, revision 1 Jan Engelhardt
2008-03-25 18:30 ` [PATCH 29/29] : Replace NF_CT_DUMP_TUPLE macro indrection by function call Jan Engelhardt
2008-03-26 20:15 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EAAED8.5040903@trash.net \
--to=kaber@trash.net \
--cc=jengelh@computergmbh.de \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox