Linux Netfilter discussions
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "Gabor Z. Papp" <gzp@papp.hu>
Cc: netfilter@vger.kernel.org,
	Netfilter Development Mailinglist
	<netfilter-devel@vger.kernel.org>,
	Netfilter Core Team <coreteam@netfilter.org>
Subject: Re: [netfilter-core] [ANNOUNCE] Release of iptables 1.4.1-rc2
Date: Tue, 27 May 2008 15:11:42 +0200	[thread overview]
Message-ID: <483C088E.4020405@trash.net> (raw)
In-Reply-To: <x6y75w3q2j@gzp>

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

Gabor Z. Papp wrote:
> * Patrick McHardy <kaber@trash.net>:
> 
> | Thanks for the report. Does this patch fix it?
> 
> Not really.
> 
>   CC       libxt_connlimit.oo
> In file included from /usr/include/linux/netfilter_ipv4.h:9,
>                  from ../include/linux/netfilter_ipv4/ip_tables.h:19,
>                  from ../include/libiptc/libiptc.h:7,
>                  from ../include/iptables.h:5,
>                  from libxt_connlimit.c:8:
> ../include/linux/netfilter.h:42: error: expected specifier-qualifier-list before '__be32'
> make[2]: *** [libxt_connlimit.oo] Error 1
> make[2]: Leaving directory `/home/gzp/src/iptables-1.4.1-rc2/extensions'
> make[1]: *** [all-recursive] Error 1

Your types.h doesn't seem to include the endian annotated
types at all. Does this patch work?


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 351 bytes --]

diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h
index 4196a51..b64a513 100644
--- a/include/linux/netfilter.h
+++ b/include/linux/netfilter.h
@@ -38,8 +38,8 @@ enum nf_inet_hooks {
 
 union nf_inet_addr {
 	__u32		all[4];
-	__be32		ip;
-	__be32		ip6[4];
+	__u32		ip;
+	__u32		ip6[4];
 	struct in_addr	in;
 	struct in6_addr	in6;
 };

  reply	other threads:[~2008-05-27 13:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-26 13:01 [ANNOUNCE] Release of iptables 1.4.1-rc2 Patrick McHardy
2008-05-27  7:11 ` Gabor Z. Papp
2008-05-27  7:35   ` [netfilter-core] " Patrick McHardy
2008-05-27 12:10     ` Gabor Z. Papp
2008-05-27 13:11       ` Patrick McHardy [this message]
2008-05-28  6:40         ` Gabor Z. Papp
2008-05-28  6:43           ` Patrick McHardy
2008-06-05 14:21             ` Patrick McHardy
2008-06-05 17:11               ` Gabor Z. Papp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483C088E.4020405@trash.net \
    --to=kaber@trash.net \
    --cc=coreteam@netfilter.org \
    --cc=gzp@papp.hu \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox